-
Notifications
You must be signed in to change notification settings - Fork 15
Fix proposals order in index #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the product review: GREAT 🎉
About the tech review: I should use the .prepend method instead of .include so we don’t need to override the entire proposals index controller. It would be better for maintainability if Decidim changes that part of the code in the future… though maybe it’s a bit superficial...
…but I don’t see any problematic breakdown here 👍
Should we not add @moustachu as reviewer ? :s
Hello, thx for your review ! I am not sure to understand the change you suggested, could you provide a detailed explanation 🙏? |
lib/extends/controllers/decidim/proposals/proposals_controller_extends.rb
Show resolved
Hide resolved
68b1d11 to
55773f8
Compare
BarbaraOliveira13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
work great locally!
🎩 Description
This PR fixes the order of proposals in paginated proposals index.
Testing
📌 Related Issues
Link your PR to an issue
Tasks