-
Notifications
You must be signed in to change notification settings - Fork 0
Feat add new features #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 Description
This PR adds different features:
It also refactor the code by adding presenters to clean models, and removes migration files that creates the models.
Testing
If you are testing from an existing app, run in the console
bundle exec rake railties:install:migrations, and thenbundle exec rake db:migrate, and eventuallybundle exec rake comments:add_referenceTesting the reference for comments:
Decidim::Comments::Comment.where(reference: nil), which should return an empty array []Decidim::Comments::Comment.all.sizeandDecidim::Comments::Comment.where.not(reference: nil).size, which should both return the same resultDecidim::Organization.first.reference_prefix, runDecidim::Comments::Comment.first.created_atand note month and year of creation, and then runDecidim::Comments::Comment.first.reference, and check that the reference is like "organization prefix"-"COMM"-"year of creation"-"month of creation"-"id"Testing the container filter:
Decidim::Assembly.where(slug: "your_assembly_slug").first.referenceand copy the referenceTesting aligment:
Tasks
📷 Screenshots
ONE

TWO

THREE
