Skip to content

Fix replace div and span by p for accessibility #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Stef-Rousset wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Fix replace div and span by p for accessibility #1292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9932ce8
fix: replace div and span by p for accesibility
Stef-Rousset Aug 29, 2025
6bb904d
refactor: change span for div and update syle
Stef-Rousset Sep 3, 2025
d90f051
refactor: remove dded class on p
Stef-Rousset Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions decidim-core/app/cells/decidim/activity/show.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
<div class="activity" data-activity>
<div class="activity__time">
<p class="activity__time">
<%= created_at %>
</div>
</p>
<div class="activity__content">
<span>
<div>
<% if title.present? %>
<span>
<p>
<%= title_icon %>
<%= title %>
</span>
</p>
<% end %>
<a href="<%= resource_link_path %>">
<%= html_truncate decidim_sanitize(resource_link_text, strip_tags: true), length: 80 %>
</a>
</span>
</div>
<% unless hide_participatory_space? %>
<span>
<%= participatory_space_link %>
Expand Down
8 changes: 4 additions & 4 deletions decidim-core/app/packs/stylesheets/decidim/_activity.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
&__content {
@apply col-span-2 md:col-span-1 order-first md:order-none space-y-2;

> span:first-child {
span {
@apply text-gray-2 text-sm;
> div:first-child {
p {
@apply text-gray-2 text-sm inline-block;

svg {
@apply text-gray fill-current;
@apply text-gray fill-current inline;
}
}

Expand Down
Loading