Skip to content

Fix improve accessibility on main_links_mobile_account #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Stef-Rousset wants to merge 46 commits into
base: develop
Choose a base branch
from
Draft

Fix improve accessibility on main_links_mobile_account #1298

Stef-Rousset wants to merge 46 commits into from

Conversation

@Stef-Rousset
Copy link

@Stef-Rousset Stef-Rousset commented Nov 6, 2025 •
edited
Loading

🎩 What? Why?

This PR improves accessibility on main_links_mobile_account, by:

  • rendering the close icon focusable, and adding a sr-only text "close"
  • adding the possibility to close modal when navigating on keyboard with space and enter keys
  • setting the focus on avatar when closing the modal with keyboard

This PR is issued from the audit of Angers city (page 29 and 30), and refers to criterias 2.5.3, 4.1.2, 1.3.1, 2.1.1, 2.4.7 and 2.4.3.

📌 Related Issues

Testing

  1. As a logged in user, go to the homepage on mobile view
  2. Click on your avatar
  3. In the account modale, navigate with your keyboard and see that the "x" for closing modal is focusable (screenshot one)
  4. Use space key or enter key to exit modal and see that the focus is set on avatar (screenshot two)
  5. Activate VoiceOver, click on avatar again, navigate with your keyboard on the "x" for closing modal and make sure you hear the word "close" .

📷 Screenshots (optional)

ONE
Capture d’écran 2025-11-06 à 16 25 14

TWO
Capture d’écran 2025-11-06 à 16 25 31

andreslucena and others added 25 commits November 14, 2025 13:36
@andreslucena
Fix for process admins accessing some components (decidim#15511)
fb12017
@andreslucena
Remove legacy images from ActiveStorage migration (decidim#15490)
e589efc
@andreslucena
Fix links in footer when using the organizations' description (decidi…
f5b9ba4 
…m#15536)
@andreslucena
Use same card for Meeting always (decidim#15535)
6355b4f
@microstudi
Fix duplicated participatory spaces in open data exports (decidim#15459)
3f63a07
@andreslucena
Fix reminder default value in legacy meetings (decidim#15528)
aa99253
@alecslupu @andreslucena
Add missing i18n string in Conference program page (decidim#15548)
8586215 
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
@andreslucena
Fix references for legacy UserGroups in Comments (decidim#15509)
b6bb7a5
@MariaDascaluPublicis @alecslupu
Fix table filter names disappear on hover in admin panel (decidim#15199)
e64961e 
Co-authored-by: Alexandru Emil Lupu <[email protected]>
@sdelcroix
Fix strong tags color in footer organization description (decidim#15552)
dafd495
@andreslucena
Use taxonomies instead of categories for the conferences' program (de…
ef14db9 
…cidim#15533)
@andreslucena
Make the admin tables a bit more consistent (decidim#15271)
9a9ea17
@alexrlpz
Include configurable restrictions for 'vote comment' action (decidim#…
8f4f427 
…15396)
@alecslupu @andreslucena
Add moderations to GraphQL API (decidim#15497)
e49712b 
* Implement changes to the GraphQL moderation types

* Add more reportable types

* Fix spec

* Fix final spec

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
@alecslupu @andreslucena
Implement changes to the GraphQL user types (decidim#15506)
e537430 
* Update API for core module

* Add various fields

* Add static pages

* Add specs for newly added classes

* Fix spec

* Add more specs

* Add user badges to the response

* Consolidate the specs - Followable

* Add specs for badges

* Fix pipeline

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Apply review recommendations

* Apply review recommendations

* Add followers spec

* Fix user report type object description

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Clarified some specs

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Update decidim-core/spec/types/static_page_topic_type_spec.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Fix static pages

* Fix taxonomy taxonomizations_count

* Add component specs

* Remove duplicated fields

* Removed the moderation related types

* Remove taxonomy related fields

* Full revert

* More reverts

* Revert change

* Remove wrong require

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
@alecslupu @MariaDascaluPublicis
@greenwoodt @andreslucena
Implement new menu in frontend (decidim#15134)
7346577 
* Remove Help, Meetings, and Activity from the header navigation

Remove unused locale

Patch the menu

* Implement breadcrumb navigation (decidim#15141)

Co-authored-by: MariaDascaluPublicis <[email protected]>

* Remove the "Global menu" content block (decidim#15135)

Co-authored-by: Tom Greenwood <[email protected]>

* Implement hamburger menu  (decidim#15132)

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: MariaDascaluPublicis <[email protected]>

* Add language chooser to header (decidim#15365)

Co-authored-by: MariaDascaluPublicis <[email protected]>
Co-authored-by: MariaDascaluPublicis <[email protected]>

* Fix header redesign found issues (decidim#15434)

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Add breadcrumb to menu (decidim#15507)

* Add breadcrumb to accountability

* Add breadcrumb to blogs

* Add breadcrumb to debates

* Add breadcrumb to collaborative_texts

* Add breadcrumb to elections

* Add breadcrumb to surveys

* Add breadcrumb to sortitions

* Add breadcrumb to proposals

* Add breadcrumb to meetings

* Fix routing errors

* Revert changes on sortitions to avoid conflicts

---------

Co-authored-by: MariaDascaluPublicis <[email protected]>
Co-authored-by: Tom Greenwood <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: MariaDascaluPublicis <[email protected]>
@greenwoodt @alecslupu
Survey responses open-data export (decidim#15492)
f57ce9f 
Co-authored-by: Alexandru Emil Lupu <[email protected]>
@andreslucena
Remove sortitions module (decidim#15563)
b86c85a
@antopalidi
Add “Maximum choices” field for Election questions (decidim#15318)
124d7a3
@decidim-bot @alecslupu
New Crowdin updates (decidim#15438)
a13d75f 
Co-authored-by: Alexandru Emil Lupu <[email protected]>
@alecslupu
Fix display conditions on survey seeds (decidim#15568)
66d0d51
@andreslucena
Clean-up the spellchecker configuration (decidim#15571)
c4f0559
@microstudi @antopalidi
Use proper action authorizer for internal census form validation (dec…
dfbfa7f 
…idim#15290)

Co-authored-by: Anna Topalidi <[email protected]>
@alecslupu @andreslucena
Update the release process documentation (decidim#15587)
200420b 
* Update the release process documentation

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Apply more review recommendations

* Run spellchecks

* Run spellchecks

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
@alecslupu @andreslucena
Improve backports documentation (decidim#15589)
55c6289 
* Improve backports documentation

* Running specll checks

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Add image and explainations

* Remove empty space

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

configuration dependencies Pull requests that update a dependency file module: accountability module: admin module: ai module: api module: assemblies module: blogs module: budgets module: collaborative_texts module: comments module: conferences module: core module: debates module: demographics module: design module: dev module: elections module: forms module: generators module: initiatives module: meetings module: pages module: participatory processes module: proposals module: sortitions module: surveys module: system module: templates module: verifications team: documentation type: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.