-
Notifications
You must be signed in to change notification settings - Fork 0
Bump module to 0.29 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stef-Rousset On peut ajouter la trad suivante pour les tos_agreement "Mit Ihrer Teilnahme akzeptieren Sie die Anmeldebedingungen"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luciegrau , c fait !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stef-Rousset Possible de retirer la majuscule à "Conditions" please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luciegrau , corrigé également 😉
Refs #522 Once the PR OpenSourcePolitics/guest-meeting-registration#1 is merged, we have to change the github branch in the Gemfile again.
Refs #522 Once the PR OpenSourcePolitics/guest-meeting-registration#1 is merged, we have to change the github branch in the Gemfile again.
Refs decidim-swiss/decidim.swiss#160 Once the PR OpenSourcePolitics/guest-meeting-registration#1 is merged, we have to change the github branch in the Gemfile again.
|
The failing tests are linked to a modal not found, triggered by a beforeunload event (The beforeunload event does not work during tests due to the deprecation of the unload event and ChromeDriver automatically accepting these dialogs). Multiple changes have been made on last version of decidim to test this, but they have not been backported to 0.29 yet. |
🎩 Description
This PR bumps the module guest_meeting_registration to 0.29 version of decidim
🎩 Related_to
Testing