Skip to content

Conversation

@Stef-Rousset
Copy link
Collaborator

@Stef-Rousset Stef-Rousset commented Apr 29, 2025

🎩 Description
This PR bumps the module guest_meeting_registration to 0.29 version of decidim

🎩 Related_to

Testing

  1. As an admin, go to a meeting, enable registration on the platform in the configuration form
  2. In the managing meeting's page, in the configure registration page, enable registration without a user account, and enable "Allow cancellation of registration"
  3. As a non logged-in user, in the FO, go to the meeting and click on the registration button. See that you have the choice to register with your account or as a guest (Test the 2 processes). See that you can cancel your registration.
  4. As an admin, go back to the configure registration page of the meeting and click on "No longer require users to choose between login and guest mode to register for the meeting". Add Registration terms.
  5. As a non logged-in user, in the FO, go to the meeting and click on the registration button. See that you can only register as a guest. See in the form that the registrations terms are displayed.
  6. As an admin, go back to the configure registration page and click enable registration form. Configure the registration form by adding one question.
  7. As a non logged-in user, in the FO, go to the meeting and click on the registration button. When you register, see that the question of the registration form is displayed. See that the labels are bold.
  8. As an admin, go to the registrations of the meeting, and click on the export. Ensure that you have both answers to registration form from guests and logged_in users.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stef-Rousset On peut ajouter la trad suivante pour les tos_agreement "Mit Ihrer Teilnahme akzeptieren Sie die Anmeldebedingungen"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luciegrau , c fait !

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stef-Rousset Possible de retirer la majuscule à "Conditions" please ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luciegrau , corrigé également 😉

@Stef-Rousset Stef-Rousset requested a review from AyakorK April 30, 2025 08:48
@Stef-Rousset Stef-Rousset marked this pull request as ready for review April 30, 2025 08:48
carlobeltrame added a commit to puzzle/decidim-zuerich that referenced this pull request May 26, 2025
Refs #522
Once the PR
OpenSourcePolitics/guest-meeting-registration#1
is merged, we have to change the github branch in the Gemfile again.
carlobeltrame added a commit to puzzle/decidim-zuerich that referenced this pull request May 27, 2025
Refs #522
Once the PR
OpenSourcePolitics/guest-meeting-registration#1
is merged, we have to change the github branch in the Gemfile again.
carlobeltrame added a commit to stadtluzern/decidim-ocl that referenced this pull request Jun 10, 2025
Refs decidim-swiss/decidim.swiss#160
Once the PR OpenSourcePolitics/guest-meeting-registration#1 is merged,
we have to change the github branch in the Gemfile again.
@Stef-Rousset
Copy link
Collaborator Author

Stef-Rousset commented Sep 4, 2025

The failing tests are linked to a modal not found, triggered by a beforeunload event (The beforeunload event does not work during tests due to the deprecation of the unload event and ChromeDriver automatically accepting these dialogs). Multiple changes have been made on last version of decidim to test this, but they have not been backported to 0.29 yet.
The last modifications on the branch were made to get the answers of the guests in the admin export of the registrations when there is a registration form. See related modifications in the last 2 commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants