Skip to content

Conversation

skinkie
Copy link

@skinkie skinkie commented Jun 20, 2014

Doing a pull request from Thalys is the best investment in time and money.

I fixed the missing StreetNetworkParams, and substituted StreetNetworkMode for the current string.

Please add some comments to the fields though.

optional double car_speed = 7;
optional double bss_speed = 9;
// Speed sounds ambigious, do you mean:
// 1) slower speak because the bicycle is fragile

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the speed depends on the user and the bike (since the bss's bike are generaly heavier than a user's the speed might be different)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants