-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Replace local / global openssl-easyrsa.cnf
#1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make pki/ca ckecks independent of other checks. Make write functions dependent on presence of Temp-dir. If openssl-easyrsa.cnf is missing then provide unexpanded here-doc copy. Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Final safe expansion will expand EASYRSA_SSL_CONF, as required by SSL library. Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
…F v2 add 'else' Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
…nssl() final expansion) Signed-off-by: Richard T Bonhomme <[email protected]>
…easyrsa.cnf Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
…ovements Signed-off-by: Richard T Bonhomme <[email protected]>
8ff6255 to
ecb6553
Compare
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Collaborator
Author
|
This also passes manual and full unit test on OpenBSD with LibreSSL 4.1.0, including Edwards curve algorithm. |
Signed-off-by: Richard T Bonhomme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Easy-RSA would create a global safe SSL config file, which is
the existing or default openssl-easyrsa.cnf file with all environment
variables expanded to their values ALWAYS.
Then Easy-RSA would create a local SSL config file for specific commands
ONLY, which is the existing or default openssl-easyrsa.cnf file with
environment variables expanded to their values ONLY when required by
the SSL library or forced to by command line option --force-safe-ssl.
With these changes, Easy-RSA now does the following:
Create a global safe SSL config file exactly as before and export it
to $OPENSSL_CONF, for use by any SSL library. This file is specifically
required by check_serial_unique(), which must have the Easy-RSA CA
configured file.
Use either an existing openssl-easyrsa.cnf file OR provide a default,
unexpanded tmp-file, which is exported to $EASYRSA_SSL_CONF, for use
ONLY by Easy-RSA. This must be unexpanded to allow $EASYRSA_REQ_CN to
be configured by the Easy-RSA command in use (eg. sign-req) once the
Easy-RSA command line has been fully parsed.
When calling easyrsa_openssl(), for LibreSSL or --force-safe-ssl,
expand the current $EASYRSA_SSL_CONF and export that to $OPENSSL_CONF,
for use by the called SSL command. Otherwise, use the current, unexpanded
file and export that.
In summary, the so-called 'local' (on-demand) SSL file has been replaced with
an ALWAYS provided or present openssl-easyrsa.cnf file, be that temporary or
packaged.