Skip to content

fix: prefer precise onnx - #249

Merged
JarbasAl merged 1 commit into
devfrom
precise_onnx
Oct 31, 2025
Merged

fix: prefer precise onnx#249
JarbasAl merged 1 commit into
devfrom
precise_onnx

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Oct 31, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Expanded wake word recognition with multiple detection engines and automatic fallback support. System can now switch between different recognition methods as needed, providing enhanced flexibility in wake word activation and ensuring consistent performance across configurations.

@coderabbitai

coderabbitai Bot commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Updates the mycroft.conf configuration file to add wake word definitions for hey_mycroft using ONNX-based and TensorFlow Lite-based precise wake word plugins, each with their respective module paths, model URLs, trigger settings, and fallback chains.

Changes

Cohort / File(s) Summary
Wake Word Configuration
ovos_config/mycroft.conf
Added hey_mycroft ONNX-based wake word plugin configuration with module, model URL, trigger_level, sensitivity, listen settings, and fallback to hey_mycroft_tflite. Added hey_mycroft_tflite TensorFlow Lite-based fallback configuration with analogous settings and fallback to hey_mycroft_precise.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify model URLs are correct and accessible
  • Confirm trigger_level and sensitivity values are within expected ranges
  • Validate fallback chain logic (hey_mycrofthey_mycroft_tflitehey_mycroft_precise)

Poem

🐰 Wake words flutter through the air,
ONNX whispers, TensorFlow care,
Fallback chains that softly guide,
Listening always, far and wide!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "fix: prefer precise onnx" accurately reflects the main change in the changeset. The configuration modifications in ovos_config/mycroft.conf establish a preference hierarchy where the ONNX-based precise wake word plugin is the primary choice with the tflite version as a fallback option. The title is concise, specific, and clearly communicates the core intent of the change without vague terminology or noise.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch precise_onnx

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a35c3e4 and fbca4e6.

📒 Files selected for processing (1)
  • ovos_config/mycroft.conf (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: unit_tests (3.11)
🔇 Additional comments (2)
ovos_config/mycroft.conf (2)

538-539: LGTM! Clear and helpful comment.

The comment accurately describes the fallback behavior and is consistent with similar explanatory comments throughout the configuration file.


531-537: Model URL verified; clarify expected_duration parameter.

The ONNX model URL is accessible and functional (19,288 bytes). The fallback chain (onnx → tflite → precise → vosk → pocketsphinx) is well-structured for graceful degradation.

However, the hey_mycroft_tflite (line 542) and hey_mycroft_precise (line 553) configurations include "expected_duration": 3, while the ONNX configuration omits it. Verify with the ovos-ww-plugin-precise-onnx plugin documentation whether this parameter is supported or required for consistency.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the fix label Oct 31, 2025
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (5cae479) to head (fbca4e6).
⚠️ Report is 203 commits behind head on dev.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #249   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         10      10           
  Lines        837     857   +20     
=====================================
- Misses       837     857   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added fix and removed fix labels Oct 31, 2025
@JarbasAl
JarbasAl merged commit 7c2c918 into dev Oct 31, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants