Skip to content

fix: include padacioso in the default intent pipeline - #275

Merged
JarbasAl merged 1 commit into
devfrom
fix/default-pipeline-padacioso
Jul 16, 2026
Merged

fix: include padacioso in the default intent pipeline#275
JarbasAl merged 1 commit into
devfrom
fix/default-pipeline-padacioso

Conversation

@JarbasAl

Copy link
Copy Markdown
Member

Summary

The shipped default intents.pipeline only lists matchers that require extra plugins (padatious, adapt, OCP, m2v). None of these ship with a bare pip install ovos-core[mycroft], while padacioso is a base dependency — yet it was absent from the pipeline. A fresh install booted and loaded skills but every utterance went unmatched.

Changes

  • Add ovos-padacioso-pipeline-plugin-high immediately after ovos-padatious-pipeline-plugin-high, so padatious keeps priority within the high-confidence tier when installed.
  • Add ovos-padacioso-pipeline-plugin-medium in the medium tier (after ovos-adapt-pipeline-plugin-medium, before the medium fallback).
  • Uninstalled plugins are skip-filtered at runtime, so existing installs are unaffected.

Tests

test/unittests/test_default_pipeline.py loads the shipped mycroft.conf through load_commented_json and asserts the padacioso entries are present and correctly ordered relative to their tier.

🤖 Generated with Claude Code

The default "intents.pipeline" only listed matchers that require extra
plugins (padatious, adapt, OCP, m2v). None of these ship with a bare
ovos-core install, while padacioso does, so a fresh install booted and
loaded skills but matched no utterances.

Add ovos-padacioso-pipeline-plugin-high right after the padatious high
matcher and ovos-padacioso-pipeline-plugin-medium in the medium tier.
Missing plugins are skip-filtered at runtime, so installs that do have
padatious keep preferring it within each confidence tier.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the fix label Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3e4a90d8-8e19-4c98-854f-1135eed0ada8

📥 Commits

Reviewing files that changed from the base of the PR and between 4174fd2 and f756459.

📒 Files selected for processing (2)
  • ovos_config/mycroft.conf
  • test/unittests/test_default_pipeline.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/default-pipeline-padacioso

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (5cae479) to head (f756459).
⚠️ Report is 245 commits behind head on dev.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #275   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         10      10           
  Lines        837     857   +20     
=====================================
- Misses       837     857   +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JarbasAl
JarbasAl marked this pull request as ready for review July 16, 2026 16:51
@JarbasAl
JarbasAl merged commit 935f1db into dev Jul 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants