Skip to content

Conversation

@bastelfreak
Copy link
Contributor

This allows us to properly depend on the job.

@bastelfreak bastelfreak self-assigned this Sep 15, 2025
@bastelfreak bastelfreak changed the title CI: Move BoltSpec tests to central workflow CI: Move BoltSpec tests to central workflow & always use Ubuntu 24.04/Windows 2025 Sep 15, 2025
@bastelfreak bastelfreak force-pushed the clean branch 4 times, most recently from e66b140 to ba1d443 Compare September 16, 2025 22:28
@bastelfreak
Copy link
Contributor Author

bastelfreak commented Sep 19, 2025

the failing test:

# frozen_string_literal: true

# This should raise a LoadError, as it's not a real gem
require 'fake'

Puppet::Functions.create_function(:load_error) do
  def load_error
    puts 'error'
  end
end

still raises a LoadError on Ruby 3.4:

bastelfreak@bastelfreak-nb ~ $ irb
irb(main):001> require 'fake'
<internal:/usr/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:136:in 'Kernel#require': cannot load such file -- fake (LoadError)
	from <internal:/usr/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:136:in 'Kernel#require'
	from (irb):1:in '<main>'
	from <internal:kernel>:168:in 'Kernel#loop'
	from /usr/lib/ruby/gems/3.4.0/gems/irb-1.14.3/exe/irb:9:in '<top (required)>'
	from /usr/bin/irb:25:in 'Kernel#load'
	from /usr/bin/irb:25:in '<main>'
irb(main):002>

bastelfreak@bastelfreak-nb ~ $ ruby -v
ruby 3.4.4 (2025-05-14 revision a38531fd3f) +PRISM [x86_64-linux]
bastelfreak@bastelfreak-nb ~ $

Edit: the actual error is coming from https://github.com/OpenVoxProject/openbolt/blob/main/spec/integration/apply_error_spec.rb#L35

@bastelfreak bastelfreak force-pushed the clean branch 3 times, most recently from 425a278 to c88e8ef Compare September 19, 2025 14:28
@bastelfreak bastelfreak force-pushed the clean branch 4 times, most recently from 65bb300 to 111d522 Compare October 10, 2025 14:19
This allows us to properly depend on the job.
@bastelfreak bastelfreak force-pushed the clean branch 3 times, most recently from 2c65a45 to a383b37 Compare October 10, 2025 15:29
@bastelfreak bastelfreak merged commit 0213f7a into main Oct 10, 2025
40 checks passed
@bastelfreak bastelfreak deleted the clean branch October 10, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants