Add MacOS signing #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This utilizes changes in Vanagon to enable signing locally, instead of shipping files to a signing server. Details for how to set this up given the appropriate certs/keys can be found on the wiki. The vox:build task will sign the individual executables (puppet, pxp-agent, wrapper.sh) inside the package. The vox:sign task will sign the package inside the dmg, and then create a new dmg with the signed package in the "signed" directory.
nmburgan
commented
May 1, 2025
| proj.signing_username 'jenkins' | ||
| proj.signing_command 'security -q unlock-keychain -p \$$OSX_SIGNING_KEYCHAIN_PW \$$OSX_SIGNING_KEYCHAIN; codesign --timestamp --keychain \$$OSX_SIGNING_KEYCHAIN -vfs \"\$$OSX_CODESIGNING_CERT\"' | ||
| proj.use_local_signing true | ||
| proj.signing_command 'codesign --timestamp --keychain $$OSX_SIGNING_KEYCHAIN -vfs "$$OSX_CODESIGNING_CERT"' |
There was a problem hiding this comment.
Because I have it set up to run as root and imported into the System keychain on my VM, we don't need to specifically unlock the keychain. Later on, when we move this into GHA, we may want a separate keychain, or we may end up doing this entirely differently.
This is checking for the presence of ticket names or (maint) in the commit message, as per Perforce policy. We don't use that, so removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes changes in Vanagon to enable signing locally, instead of shipping files to a signing server. Details for how to set this up given the appropriate certs/keys can be found on the wiki.
The vox:build task will sign the individual executables (puppet, pxp-agent, wrapper.sh) inside the package. The vox:sign task will sign the package inside the dmg, and then create a new dmg with the signed package in the "signed" directory.
This also removes the "commit" PR check, since we don't require adding ticket numbers or (maint) to each commit message like Perforce does.