include "local" facts in facts output #240
Open
+17
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some years ago [a bug was filed](https://puppet.atlassian.net/browse/PUP-10717) noting that `puppet facts show` appended all local facts when called with one or more specific facts. This was resolved by simply not including local facts for this specific subcommand. This had the unfortunate side effect that something like `puppet facts show clientcert` no longer displayed anything. (note: you could still run `puppet config print certname` but that takes a LOT of institutional knowledge to know that those are the same thing.) Worse, when we added the `implementation` local fact, it also didn't display. This PR just returns to including the local facts into `puppet fact show` output, but only the ones requested or when requesting all facts. Fixes OpenVoxProject#220
nmburgan
approved these changes
Nov 17, 2025
Comment on lines
+30
to
+31
| def add_local_facts(query = []) | ||
| query = Array(query) # some use cases result in a nil being passed in |
Member
There was a problem hiding this comment.
Very slightly less boilerplate, but totally fine as-is too.
Suggested change
| def add_local_facts(query = []) | |
| query = Array(query) # some use cases result in a nil being passed in | |
| def add_local_facts(query) | |
| query ||= [] # some use cases result in a nil being passed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some years ago a bug was filed
noting that
puppet facts showappended all local facts when called withone or more specific facts. This was resolved by simply not including
local facts for this specific subcommand.
This had the unfortunate side effect that something like
puppet facts show clientcertno longer displayed anything. (note: you could stillrun
puppet config print certnamebut that takes a LOT of institutionalknowledge to know that those are the same thing.) Worse, when we added
the
implementationlocal fact, it also didn't display.This PR just returns to including the local facts into
puppet fact showoutput, but only the ones requested or when requesting all facts.
Fixes #220