Fix transient failure in touch-parameters-test #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Before this commit, I hit the transient twice in 25 test runs. After this commit, I had 100 successful runs in a row. |
nmburgan
approved these changes
Jan 8, 2026
Member
|
Different transient? |
touch-parameter-value for strings could return the identical string, causing touch-parameters to produce unchanged output. This happened when empty strings were selected or random generation happened to produce the same string (which is only plausible for _very_ short strings). Fix by converting empty strings to single character so that the string is different and retrying up to 5 times for non-empty strings.
austb
force-pushed
the
fix-transient-benchmark-test
branch
from
80f4306 to
c2362b6
Compare
Contributor
Author
|
I think that transient was me missing a test that need a small tweak after my change. I think that force push should do it. |
bastelfreak
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
touch-parameter-value for strings could return the identical string, causing touch-parameters to produce unchanged output. This happened when empty strings were selected or random generation happened to produce the same string (which is only plausible for very short strings).
Fix by converting empty strings to single character so that the string is different and retrying up to 5 times for non-empty strings.