-
Notifications
You must be signed in to change notification settings - Fork 8
Update dependencies and namespace #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2026
Merged
492b4ef to
559a8ff
Compare
559a8ff to
1be42e6
Compare
6596ff4 to
5ae1a62
Compare
This reverts commit 1df6048.
In 42.7.7 (pgjdbc/pgjdbc#3757) pgjdbc broke parameters set via (.setObject stmt i (doto (PGobject.) (.setType "bytea") (.setValue "\x42abcdef))) which is the way pdb has handled them, whether explicitly, or indirectly via clojure.java.jdbc and next.jdbc, which both default to (.setObject ...) for parameter types without a more specific protocol extension. While this is intended to work (see the issue thread), the pgjdbc documentation specifies `.setBytes` for bytea parameters, and `.setArray` for arrays of bytea: https://jdbc.postgresql.org/documentation/binary-data/ https://jdbc.postgresql.org/documentation/server-prepare/#arrays Add new PDBBytea and VecPDBBytea classes for the bytea and bytea[] parameters and extend the relevant clojure.java.jdbc and next.jdbc protocols to call the appropriate PreparedStatement method for each, rather than the `.setObject` default. Note that we cannot use defrecords because (by default) honeysql would treat them as unrecognized extensions. [[email protected]: remove unused import, fix typo, add hashCode method to PDBBytea] Reviewed-by: Austin Blatt <[email protected]>
bastelfreak
approved these changes
Jan 7, 2026
austb
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.