-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Binder net packet reader io #1464
base: dev
Are you sure you want to change the base?
Conversation
|
Can't look at the engine code right now to find the place where we actually write size_t to a net packet, so I just briefly say that we should never use size_t in net packets and binary formats, so we need to change the code to write u32 as it was before. |
I would stick with u32. Then |
We write size of magazine here
And get
Should I just do static cast to u32 to make it work? |
@Neloreck I agree! |
…ity in 32 and 64 bit.
Now we need to analyze all changes we have and merge everything that breaks saves compatibility within one time period (e.g. a day?) |
143d1ca
to
118d39d
Compare
5b2ec76
to
6fffce9
Compare
e89fcc8
to
f6fd5cc
Compare
Changes