Skip to content

Fix for crash when TextReplacer when replacement string is empty. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: vNext
Choose a base branch
from
Open

Fix for crash when TextReplacer when replacement string is empty. #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion OpenXmlPowerTools/TextReplacer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ private static object WmlSearchAndReplaceTransform(XNode node,
return (object)g;
string textValue = g.Select(r => r.Element(W.t).Value).StringConcatenate();
XAttribute xs = null;
if (textValue[0] == ' ' || textValue[textValue.Length - 1] == ' ')
if (textValue.Length > 0 && (textValue[0] == ' ' || textValue[textValue.Length - 1] == ' '))
xs = new XAttribute(XNamespace.Xml + "space", "preserve");
return new XElement(W.r,
g.First().Elements(W.rPr),
Expand Down
4 changes: 3 additions & 1 deletion OpenXmlPowerToolsExamples/TextReplacer02/TextReplacer02.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ static void Main(string[] args)
var tempDi = new DirectoryInfo(string.Format("ExampleOutput-{0:00}-{1:00}-{2:00}-{3:00}{4:00}{5:00}", n.Year - 2000, n.Month, n.Day, n.Hour, n.Minute, n.Second));
tempDi.Create();

DirectoryInfo di2 = new DirectoryInfo("../../");
DirectoryInfo di2 = new DirectoryInfo("../../../");
foreach (var file in di2.GetFiles("*.docx"))
file.CopyTo(Path.Combine(tempDi.FullName, file.Name));

Expand Down Expand Up @@ -50,6 +50,8 @@ static void Main(string[] args)
TextReplacer.SearchAndReplace(doc, "the", "this", true);
using (WordprocessingDocument doc = WordprocessingDocument.Open(Path.Combine(tempDi.FullName, "Test09.docx"), true))
TextReplacer.SearchAndReplace(doc, "===== Replace this text =====", "***zzz***", true);
using (WordprocessingDocument doc = WordprocessingDocument.Open(Path.Combine(tempDi.FullName, "Test09.docx"), true))
TextReplacer.SearchAndReplace(doc, "***zzz***", "", true);
}
}
}