-
Notifications
You must be signed in to change notification settings - Fork 9
Add compact fmt #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andrew-fleming
wants to merge
43
commits into
OpenZeppelin:main
Choose a base branch
from
andrew-fleming:add-compact-fmt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add compact fmt #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an
x
in the boxes that applyFixes #240.
PR Checklist
Overview
This PR proposes to add the
compact format
feature from Compact dev tools. To better support this feature, and forthcoming features, this PR proposes to refactor the compiler workflow (again) by utilizing an abstract BaseServices module that can be easily extended for more features. This approach provides consistency and allows each feature to be tested well.This PR also proposes to change
fmt-and-lint
to simplycheck
i.e.check
andcheck:fix
(which follows biome's naming convention). The idea is to better delineate Compact formatting and TS formatting (via biome). This also keeps the command shortFinally, this PR includes proper formatting for Compact modules and mock contracts
Additions
format
andformat:fix
commandsChanges
fmt-and-lint
tocheck
useLiteralKeys: false
in biome (to simplify testing)Waiting on #233 (requires compact v0.25.0)