feat: Plat-6104 prevent sdk retries on 500 error (#689)

* feat: prevent sdk retries on 500 errors * chore: remove files * chore: remove files
OpenZeppelin · Feb 5, 2025 · 0ff02ed · 0ff02ed
1 parent bcfcedf
commit 0ff02ed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/examples/relayer-signer-actions/package.json b/examples/relayer-signer-actions/package.json
@@ -12,4 +12,4 @@
     "@openzeppelin/defender-sdk": "2.1.0",
     "dotenv": "^16.3.1"
   }
-}
+}
diff --git a/packages/base/src/api/client.ts b/packages/base/src/api/client.ts
@@ -137,6 +137,11 @@ export abstract class BaseApiClient {
         throw new Error('API Key is either expired or invalid');
       }
 
+       // by default no retries on 500 errors except for Cloudflare errors
+      if (isInternalServerError(error) && !isCloudFlareError(error)) {
+        throw error;
+      }
+
       // this means ID token has expired so we'll recreate session and try again
       if (isAuthenticationError(error)) {
         this.api = undefined;
@@ -183,6 +188,9 @@ const isAuthenticationError = (axiosError: AxiosError): boolean =>
 const isCloudFlareError = (axiosError: AxiosError): boolean =>
   axiosError.response?.status === 520 && (axiosError.response?.data as string).includes('Cloudflare');
 
+const isInternalServerError = (axiosError: AxiosError): boolean =>
+  axiosError.response?.status ? axiosError.response.status >= 500 : false;
+
 export const exponentialDelay = (
   retryNumber = 0,
   _error: AxiosError | undefined = undefined,
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,4 +12,4 @@ @@
         "@openzeppelin/defender-sdk": "2.1.0",
         "dotenv": "^16.3.1"
       }
-    }
+    }