Skip to content

docs: convert <T>::ZERO doc references to links#643

Merged
bidzyyys merged 10 commits intoOpenZeppelin:sdk-v0.9-and-ctorsfrom
YanVictorSN:docs-references-links
May 16, 2025
Merged

docs: convert <T>::ZERO doc references to links#643
bidzyyys merged 10 commits intoOpenZeppelin:sdk-v0.9-and-ctorsfrom
YanVictorSN:docs-references-links

Conversation

@YanVictorSN
Copy link
Contributor

@YanVictorSN YanVictorSN commented Apr 29, 2025 •
edited by 0xNeshi
Loading

Towards #642

Hi @0xNeshi Should i do the same for S::Value::Zero ?

PR Checklist

  • Tests
  • Documentation
  • Changelog

nickventon and others added 2 commits April 29, 2025 10:05
@nickventon @bidzyyys
test: Rename e2e test files based on directory (OpenZeppelin#629)
20ffabe 
<!--
Thank you for your interest in contributing to OpenZeppelin!

Consider opening an issue for discussion prior to submitting a PR. New
features will be merged faster if they were first discussed and designed
with the team.

Describe the changes introduced in this pull request. Include any
context necessary for understanding the PR's purpose.
-->

<!-- Fill in with issue number -->
Resolves OpenZeppelin#443 

#### PR Checklist

<!--
Before merging the pull request all of the following must be completed.
Feel free to submit a PR or Draft PR even if some items are pending.
Some of the items may not apply.
-->

- [ ] Tests
- [ ] Documentation
- [ ] Changelog

---------

Co-authored-by: Daniel Bigos <daniel.bigos@openzeppelin.com>
@YanVictorSN
docs: convert <T>::ZERO doc references to links
79270e3
@netlify
Copy link

netlify bot commented Apr 29, 2025 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 95394de
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/681e38a1b6d49f000837d5f2

@0xNeshi
Copy link
Collaborator

0xNeshi commented Apr 30, 2025

Thanks @YanVictorSN , we'll be reviewing when we free up our backlog a bit.

Should i do the same for S::Value::Zero ?

Sure if you can make it a navigable link. Otherwise, leave it as-is

@YanVictorSN
Copy link
Contributor Author

YanVictorSN commented May 5, 2025

Thanks @YanVictorSN , we'll be reviewing when we free up our backlog a bit.

Should i do the same for S::Value::Zero ?

Sure if you can make it a navigable link. Otherwise, leave it as-is

That's ok. Thanks!

@0xNeshi
Copy link
Collaborator

0xNeshi commented May 6, 2025 •
edited
Loading

Fix failing CI for formatting, ignore the e2e and gas-bench ones as those will be fixed in a separate PR (related to #648)

@YanVictorSN
Copy link
Contributor Author

YanVictorSN commented May 9, 2025

Fix failing CI for formatting, ignore the e2e and gas-bench ones as those will be fixed in a separate PR (related to #648)

@0xNeshi Just fixed! Thanks.

0xNeshi
0xNeshi approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

bidzyyys
bidzyyys approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @YanVictorSN!
Should be merged to v0.2 branch.

@bidzyyys bidzyyys changed the base branch from main to v0.2 May 14, 2025 07:43
@bidzyyys bidzyyys changed the base branch from v0.2 to main May 14, 2025 07:45
@bidzyyys bidzyyys changed the base branch from main to v0.2 May 14, 2025 07:45
@bidzyyys bidzyyys changed the base branch from v0.2 to sdk-v0.9-and-ctors May 14, 2025 07:48
@bidzyyys bidzyyys self-requested a review May 14, 2025 07:48
@0xNeshi
Copy link
Collaborator

0xNeshi commented May 14, 2025

@YanVictorSN since we changed the PR's target branch, we'll be handling the conflict resolution.

Thanks for contributing, feel free to fix other doc links that may exist or go ahead and pick another issue to work on 👍

@0xNeshi 0xNeshi mentioned this pull request May 15, 2025
Merged
@bidzyyys bidzyyys merged commit 24e93b7 into OpenZeppelin:sdk-v0.9-and-ctors May 16, 2025
6 of 13 checks passed
@bidzyyys bidzyyys linked an issue May 16, 2025 that may be closed by this pull request
[Feature]: Convert all <T>::ZERO (e.g. Address::ZERO) doc references to links #642
Closed
1 task
@bidzyyys bidzyyys mentioned this pull request May 16, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xNeshi 0xNeshi 0xNeshi approved these changes

@bidzyyys bidzyyys bidzyyys approved these changes

@qalisander qalisander Awaiting requested review from qalisander

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Convert all <T>::ZERO (e.g. Address::ZERO) doc references to links

4 participants

@YanVictorSN @0xNeshi @bidzyyys @nickventon