Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fungible Token #13

Merged
merged 10 commits into from
Jan 23, 2025
Merged

Fungible Token #13

merged 10 commits into from
Jan 23, 2025

Conversation

brozorec
Copy link
Collaborator

@brozorec brozorec commented Jan 15, 2025 •
edited
Loading

Fixes #5

PR Checklist

  • Tests
  • Documentation

@brozorec
Copy link
Collaborator Author

brozorec commented Jan 17, 2025 •
edited
Loading

The PR doesn't handle extending of persistent and instance storage entries. The idea is to have an additional tool for doing that as defined in #4. While working on this PR, I started to consider bumping persistent is better to be treated in the module where the raw access to storage is possible. Despite this, I'm passing the PR for review and this has to be further researched and designed.

@brozorec brozorec marked this pull request as ready for review January 17, 2025 15:33
@brozorec brozorec assigned ozgunozerk and brozorec and unassigned ozgunozerk Jan 17, 2025
@brozorec brozorec requested a review from ozgunozerk January 22, 2025 09:22
ozgunozerk
ozgunozerk reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@ozgunozerk ozgunozerk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! Wonderful work 💯

Just a single question below 👇

@brozorec brozorec requested a review from ozgunozerk January 22, 2025 13:23
@brozorec brozorec added this to the Release v0.1.0 milestone Jan 22, 2025
@brozorec brozorec mentioned this pull request Jan 22, 2025
Closed
1 task
@brozorec brozorec merged commit 6655643 into main Jan 23, 2025
2 checks passed
@brozorec brozorec deleted the fungible-token branch January 23, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozgunozerk ozgunozerk ozgunozerk approved these changes

Assignees

@brozorec brozorec

Labels
None yet
Projects
Stellar Contracts
Status: Done
Milestone
Release v0.1.0
Development

Successfully merging this pull request may close these issues.

🏗️ [Core Feature]: Fungible Token Standard (Erc20)
2 participants
@brozorec @ozgunozerk