Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burnable #15

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Burnable #15

merged 8 commits into from
Jan 24, 2025

Conversation

ozgunozerk
Copy link
Collaborator

Fixes #7

This PR implements Burnable extension for Fungible Token. And fixes some minor issues along the way:

  • Simplify issue template
  • change value to amount in the codebase for the coherence with Stellar ecosystem
  • use &Env everywhere instead of Env to allow more flexibility

Note: I’m usually biased towards introducing 1-2 changes per PR for keeping the scope narrow. But since the [value to amount] and [Env to &Env] changes are quite straight-forward and minimal, I’ve thought the effort required to separate them into other PRs would be a waste of time.

Second note: this is based against fungible-token branch for now to ease the review process, and hence is a draft PR. Once Fungible Token PR merges, this should be rebased against main.

@ozgunozerk ozgunozerk added this to the Release v0.1.0 milestone Jan 21, 2025
@ozgunozerk ozgunozerk requested a review from brozorec January 21, 2025 12:04
@ozgunozerk ozgunozerk self-assigned this Jan 21, 2025
@ozgunozerk ozgunozerk linked an issue Jan 21, 2025 that may be closed by this pull request
1 task
Copy link
Collaborator

@brozorec brozorec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 💪

@ozgunozerk ozgunozerk requested a review from brozorec January 22, 2025 09:00
@brozorec brozorec force-pushed the fungible-token branch 2 times, most recently from 0cba749 to c3c10db Compare January 22, 2025 09:41
Base automatically changed from fungible-token to main January 23, 2025 07:03
@ozgunozerk ozgunozerk marked this pull request as ready for review January 23, 2025 15:30
@ozgunozerk ozgunozerk requested a review from brozorec January 23, 2025 15:30
@ozgunozerk ozgunozerk merged commit 17556a7 into main Jan 24, 2025
2 checks passed
@ozgunozerk ozgunozerk deleted the burnable branch January 24, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🏗️ [Core Feature]: Burnable
2 participants