-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burnable #15
Merged
Merged
Burnable #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
brozorec
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job 💪
brozorec
requested changes
Jan 22, 2025
0cba749
to
c3c10db
Compare
brozorec
requested changes
Jan 22, 2025
1 task
brozorec
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
This PR implements
Burnable
extension forFungible Token
. And fixes some minor issues along the way:value
toamount
in the codebase for the coherence with Stellar ecosystem&Env
everywhere instead ofEnv
to allow more flexibilityNote: I’m usually biased towards introducing 1-2 changes per PR for keeping the scope narrow. But since the [
value
toamount
] and [Env
to&Env
] changes are quite straight-forward and minimal, I’ve thought the effort required to separate them into other PRs would be a waste of time.Second note: this is based against
fungible-token
branch for now to ease the review process, and hence is a draft PR. OnceFungible Token
PR merges, this should be rebased against main.