Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[N-04] Unclear Revert Reason #54

Open
wants to merge 4 commits into
base: zero-transfers
Choose a base branch
from
Open

[N-04] Unclear Revert Reason #54

wants to merge 4 commits into from

Conversation

brozorec
Copy link
Collaborator

@brozorec brozorec commented Feb 12, 2025 •
edited
Loading

fix #44

@brozorec brozorec added the audit label Feb 12, 2025
@brozorec brozorec requested a review from ozgunozerk February 12, 2025 10:15
@brozorec brozorec self-assigned this Feb 12, 2025
@brozorec
Copy link
Collaborator Author

Must be merged after #48 to avoid conflicts because both touch on errors in fungible.

ozgunozerk
ozgunozerk requested changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@ozgunozerk ozgunozerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one optimization in terms of functional style, approved!

contracts/token/fungible/src/extensions/metadata/storage.rs Outdated Show resolved Hide resolved
brozorec and others added 2 commits February 12, 2025 13:42
@brozorec @ozgunozerk
use unwrap_or_else
800abfb 
Co-authored-by: Özgün Özerk <[email protected]>
@brozorec
fmt
5737528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozgunozerk ozgunozerk ozgunozerk approved these changes

Assignees

@brozorec brozorec

Labels
audit
Projects
Stellar Contracts
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brozorec @ozgunozerk