[M-01] Approval Periods Are Implicitly Restricted #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #35
The audit report suggests two ways of addressing this issue:
and
We acknowledge the reasoning behind this suggestions, but decided to keep the current design of implicitly restricted approvals. The main reason is consistency with SAC (Stellar Asset Contract), where temporary storage is used for this data and one can't set a longer TTL than the max allowed. However, we introduce an explicit check/error for the case when
live_until_ledger > max_live_until_ledger
and explain this limitation in the docs.