[L-04] Instance TTL Not Updated on All Operations #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brozorec
approved these changes
Feb 14, 2025
| @@ -62,6 +62,11 @@ | |||
| //! - **Composable Design**: The modular structure encourages developers to | |||
| //! extend functionality by combining provided primitives or creating custom | |||
| //! extensions. | |||
| //! - **TTL management**: This library handles the TTL of only `temporary` and | |||
| //! `persistent` storage entries declared by the library. The `instance` TTL | |||
| //! management is left to the implementor due to flexibility. Our library | |||
There was a problem hiding this comment.
Suggested change
| //! management is left to the implementor due to flexibility. Our library | |
| //! management is left to the implementor due to flexibility. The library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
PR Checklist
Notes: now, every operation in
Fungible*extends TTL, the only exception beingMetadata, because it is slightly different than transaction operations, and users of the library may want to implement their own TTL strategy for that.For some methods in
Fungible*, you will see thatextend_ttl()is not there. The reason is, the inner functions/methods these methods are calling have theextend_ttl(), hence, the duplication was not necessary.