Fix error notification #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error notification is shown if two or more streams are available, but it should only be displayed if there are no streams.
ferishili
approved these changes
Nov 22, 2024
|
Did you rebase it or merge a branch into that one because of a merge commit? What's the improvement? Because the error notification is now removed. |
Yes, I wrote that I rebase and merged. The part to handle that, was merged before via: f48a850 |
|
So basically, a duplicate of that PR got merged before this one, which was created almost 3 months later. |
|
Unfortunately, it does seem that way. It looks like this PR might have been impacted by changes in personnel and limited time for repository management when it was originally created. Apologies for any inconvenience, and thank you for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error notification is shown if two or more streams are available, but it should only be displayed if there are no streams.