Skip to content

Comments

Add v major regexp#65

Merged
justinmchase merged 9 commits intoOptum:mainfrom
rslayman:add-v-major-regexp
May 14, 2024
Merged

Add v major regexp#65
justinmchase merged 9 commits intoOptum:mainfrom
rslayman:add-v-major-regexp

Conversation

@rslayman
Copy link
Contributor

@rslayman rslayman commented May 13, 2024

Proposed changes

Add support for vMajor versions that are often used in GitHub Actions and Workflows.

Building off of the previously utilized variant field, creating new VariantKey typeversion_major that when used with the example semver value of 1.2.3 will have a version_major value of v1.

Example:

- kind: regexp
  pattern: '(?<=org/my-cool-actions/.*@).*'
  flags: g
  variant: version_major

Changes after PR Review

  1. Changed variant naming convention to format. Based on review comment
  2. Updated FormatKind (previously VariantKey) fields to match naming convention. Based on review comment
  3. Added new regexp optional parameter prefix to allow for user customized prefix values on generated versions. Based on review comment
- kind: regexp
  pattern: '(?<=org/my-cool-actions/.*@).*'
  flags: g
  file: ./.github/README.md
  format: major
  prefix: v

@rslayman rslayman requested a review from justinmchase as a code owner May 13, 2024 23:06
@rslayman
Copy link
Contributor Author

@justinmchase updates have been made per your review comments.

@justinmchase justinmchase merged commit 5bcdd47 into Optum:main May 14, 2024
@rslayman rslayman deleted the add-v-major-regexp branch May 14, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants