Improve ShapeResult functionality#19269
Draft
gvkries wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way display and editor shapes are initialized throughout multiple OrchardCore modules. The main improvement is the adoption of strongly-typed and static initialization patterns for shape factories and view models, which enhances type safety, testability, and clarity. Additionally, dependencies are now passed explicitly to initialization methods, reducing reliance on closures and instance fields.
The most important changes are:
Refactoring Shape/ViewModel Initialization:
InitializeandShapecalls with strongly-typed, static lambda overloads (e.g.,Initialize<TViewModel, TDependency1, ...>,Factory) across various display drivers, ensuring all dependencies are explicitly passed and improving code maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Explicit Dependency Injection in Shape Initialization:
Improved Conditional Rendering:
RenderWhencalls to use static lambdas and explicit dependency injection, making conditional rendering logic more robust and explicit. [1] [2] [3] [4]Consistency and Modernization:
Minor Cleanups: