Skip to content

Comments

Security and core updates for PHP 8.5 and s6-overlay v3#13

Open
metalcated wants to merge 4 commits intoOrganizr:masterfrom
metalcated:security/core-updates
Open

Security and core updates for PHP 8.5 and s6-overlay v3#13
metalcated wants to merge 4 commits intoOrganizr:masterfrom
metalcated:security/core-updates

Conversation

@metalcated
Copy link

  • Upgrade s6-overlay from v2.2.0.3 to v3.2.1.0
  • Add s6 v3 compatibility symlinks (with-contenv, execlineb)
  • Add php symlink to php85 for compatibility
  • Fix PHP 8.5 socket naming consistency
  • Fix execute permissions on init and service scripts

- Upgrade s6-overlay from v2.2.0.3 to v3.2.1.0
- Add s6 v3 compatibility symlinks (with-contenv, execlineb)
- Add php symlink to php85 for compatibility
- Fix PHP 8.5 socket naming consistency
- Fix execute permissions on init and service scripts
Required for JWT token validation with newer versions of
lcobucci/jwt that use sodium for signature verification.
Copy link
Member

@Roxedus Roxedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not accept a half implemented S6v3 transition.

- Update all init scripts to use /command/with-contenv shebang
- Update all service scripts to use /command/with-contenv shebang
- Remove compatibility symlinks from Dockerfiles (no longer needed)
- Add support for child images to provide /defaults/php-local.ini
@metalcated
Copy link
Author

You're right man. Half ass with the symlinks. Fixed.

@metalcated metalcated requested a review from Roxedus February 14, 2026 00:54
@Roxedus
Copy link
Member

Roxedus commented Feb 15, 2026

With s6v3 there's no guaranteed execution order for services in cont-init.d,(though, the execution is lexical, and it might seem to be the case) and would need to be redone with a dependency graph, ie like ive done here linuxserver/docker-apprise-api@e3dfd19

Replace cont-init.d and services.d with proper s6-rc.d structure:
- init-adduser -> init-config -> init-setup -> init-debug -> init-services
- svc-nginx, svc-php-fpm, svc-cron depend on init-services
- Explicit dependency declarations instead of lexical ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants