Repository navigation
build: bloc_concurrency מהענף המשולב לאחר QA ותיקוני upstream - #4808
Merged
Merged
Conversation
Collaborator
|
סקירת הקוד הסתיימה ללא ממצא חוסם, כולל השוואת קוד דחפתי תיקון CI ושילבתי את אימות לפני הדחיפה: |
Collaborator
|
@Y-PLONI |
This was referenced Nov 10, 2026
Y-PLONI
force-pushed
the
palmoni5/bloc-concurrency-integration-20261110
branch
from
November 10, 2026 22:36
4580399 to
3516be0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bloc_concurrencynow comes from the combined branch of our fork, Otzaria/bloc (master@6e4061e3), instead of pub.dev 0.3.0. The fork'smasteris upstreamfelangel/blocmaster plus every fork PR that was merged after QA.Changes relevant to the app (we use
droppablein the library, andrestartable/sequentialin other blocs):listen()reaches the stream as an error, not an uncaught zone error. Later events are still handled.concurrent,sequentialandrestartable.The fork round
try)Every fork PR passed the full CI (format, analyze, bloc lint, tests, 100% coverage) before merging. CI ran in a mirror repo, because Actions are disabled in the fork.
For the reviewer
pubspec.yaml: switch back to pub.dev after fix(bloc_concurrency): close droppable stream when source ends mid-event felangel/bloc#4829, [דיווח מהתוכנה] שם הספר באיתור עם ראשי תיבות #4894 and [תקיעה] התוכנה נתקעה (10 שניות) #4913–חיפוש חכם: תדירות עדכון, בדיקת רכיב ההרצה לפני הורדה ורישום כשלים #4916 are merged and released.masterof Otzaria/bloc, then update therefhere) and to the matching upstream PR branch inpalmoni5/bloc(bloc_concurrency/*).Checks
flutter analyze: no issues.flutter test test/library test/history test/tabs test/find_ref test/indexing test/personal_notes: all passed (+3160).Overlapping PRs
Open PRs that touch
pubspec.yaml/pubspec.lock: #4801, #4793, #4791, #4776, #4767, #4731 merge cleanly with this one. #4762 and #4343 already conflict withdevitself, regardless of this change.