Skip to content

build: bloc_concurrency מהענף המשולב לאחר QA ותיקוני upstream - #4808

Merged
Y-PLONI merged 1 commit into
devfrom
palmoni5/bloc-concurrency-integration-20261110
Nov 10, 2026
Merged

Y-PLONI merged 1 commit into
devfrom
palmoni5/bloc-concurrency-integration-20261110

Conversation

@palmoni5

Copy link
Copy Markdown
Member

Summary

bloc_concurrency now comes from the combined branch of our fork, Otzaria/bloc (master @ 6e4061e3), instead of pub.dev 0.3.0. The fork's master is upstream felangel/bloc master plus every fork PR that was merged after QA.

Changes relevant to the app (we use droppable in the library, and restartable/sequential in other blocs):

  • droppable: the output closes when the source ends while an event is still being handled, and doesn't hang.
  • droppable: a synchronous error thrown by the mapper or by listen() reaches the stream as an error, not an uncaught zone error. Later events are still handled.
  • droppable: on cancel, the source subscription is released without waiting for the active handler's cancellation.
  • Documentation and tests for the scheduling guarantees of concurrent, sequential and restartable.

The fork round

Fork PR Result Upstream
Otzaria/bloc#1 (droppable completion + mapper errors) Merged after QA (strengthened test) Duplicate of existing PRs by others: felangel/bloc#4829, felangel/bloc#4894. No new PR opened
Otzaria/bloc#2 (transformer tests + docs) Merged after QA (2 tests added) Split: felangel/bloc#4913 (tests), felangel/bloc#4914 (docs; overlaps felangel/bloc#4819)
Otzaria/bloc#3 (backpressure + parallel cancellation) Narrowed to parallel cancellation only, then merged. The pause/resume part has no effect inside bloc and changed semantics felangel/bloc#4915
Otzaria/bloc#4 (listen() errors) Merged after QA (single shared try) felangel/bloc#4916 (built on felangel/bloc#4894)

Every fork PR passed the full CI (format, analyze, bloc lint, tests, 100% coverage) before merging. CI ran in a mirror repo, because Actions are disabled in the fork.

For the reviewer

Checks

  • flutter analyze: no issues.
  • flutter test test/library test/history test/tabs test/find_ref test/indexing test/personal_notes: all passed (+3160).

Overlapping PRs

Open PRs that touch pubspec.yaml/pubspec.lock: #4801, #4793, #4791, #4776, #4767, #4731 merge cleanly with this one. #4762 and #4343 already conflict with dev itself, regardless of this change.

yom-chadash commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

סקירת הקוד הסתיימה ללא ממצא חוסם, כולל השוואת קוד bloc_concurrency לגרסת השחרור 0.3.0 ובדיקת הצרכנים באוצריא.

דחפתי תיקון CI ושילבתי את dev@cc9cb1e: תקציב Live WebView2 resource scenario הוגדל מ־30 ל־45 דקות. בלוג הקודם הבנייה והתרחיש הראשון עברו, אבל התרחיש השני קיבל רק 18.5 שניות לפני מגבלת ה־job. הבדיקות, הספים ומגבלות הזמן הפנימיות לא השתנו.

אימות לפני הדחיפה: flutter analyze מלא ללא ממצאים; 18 בדיקות הספרייה ו־10 בדיקות Node של תרחיש ה־WebView עברו. תוכן הקומיט שנדחף זהה לעץ הקוד שאומת. ממתין לתוצאות ה־CI על הראש החדש לפני הודעת הקבלה.

Copy link
Copy Markdown
Collaborator

@Y-PLONI
ניתן לקבל.

@Y-PLONI
Y-PLONI force-pushed the palmoni5/bloc-concurrency-integration-20261110 branch from 4580399 to 3516be0 Compare November 10, 2026 22:36
@Y-PLONI
Y-PLONI merged commit ea1f00d into dev Nov 10, 2026
31 checks passed
@Y-PLONI
Y-PLONI deleted the palmoni5/bloc-concurrency-integration-20261110 branch November 10, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants