-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unnecessary time frequency resampling #2112
Avoid unnecessary time frequency resampling #2112
Conversation
Warning This Pull Request is coming from a fork and must be manually tagged |
Hi @Hem-W ! Thanks for your insight here and in your issue. That's a great point. I think constraining the fast implementation to @aulemahal @Zeitsperre , have your thoughts evolved on the inclusion of flox by default or not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works!
Co-authored-by: Pascal Bourgault <[email protected]>
@coxipi Outside the CI issues (being addressed elsewhere), it looks like there's one actual failing test:
Once the CI has been fixed here, could you quickly verify that this is expected? |
@Hem-W Thanks so much for the code contribution! |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
preprocess_standardized_index
whenfreq
is not None but the same as the input data.Does this PR introduce a breaking change?
No
Other information:
I am thinking whether it is necessary to prompt users to install
flox
when they input dask datasets and require time resampling.