Add solar interpolation module - #2386
Conversation
Zeitsperre
left a comment
There was a problem hiding this comment.
Neat additions!
I think you should rebase on the dev-v099 branch since we're so close to the release for it. If we do put out a final v0.x version, it shouldn't have any brand new modules.
The v1 candidate branch has more subdivided extra dependencies, so it might make sense to add a new one (xclim[solar]?).
…ts if library doesn't exist.
aulemahal
left a comment
There was a problem hiding this comment.
First pass before leaving for two weeks so I don't need to explain it any further.
Zeitsperre
left a comment
There was a problem hiding this comment.
This is looking really good. I'm going to restate though that this should be added to the first v1 release, given that it adds a bunch of new features and refactors several existing functions into a new (albeit much more sensible) location.
Is there a delivery date involved here or are things OK to stay as a PR for the next month or two?
This is fine, I'll just point towards this branch and ask them to install locally. |
| @@ -0,0 +1,1194 @@ | |||
| """The solar module offers functions for interpolating and accumulating variables to solar noon.""" | |||
There was a problem hiding this comment.
| """The solar module offers functions for interpolating and accumulating variables to solar noon.""" | |
| """The solar module offers helper functions for astronomical calculations related to the sun, its position in the sky, its revolution and to the length of day.""" |
| try: | ||
| from flox.xarray import rechunk_for_blockwise | ||
|
|
||
| flox_err = None | ||
| except ImportError: | ||
| rechunk_for_blockwise = None | ||
|
|
There was a problem hiding this comment.
| try: | |
| from flox.xarray import rechunk_for_blockwise | |
| flox_err = None | |
| except ImportError: | |
| rechunk_for_blockwise = None |
I believe this was copied from the helpers, but is not actually needed ? I think it's for resample_map which still resides in the other file.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information:
Todo: