Skip to content

CLR绑定:函数参数有多维数组报错修改 #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

CLR绑定:函数参数有多维数组报错修改 #730

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f90bafe
Update Extensions.cs
chenxihan Sep 28, 2022
9bc0856
CLR绑定多维数组参数报错
chenxihan Oct 7, 2022
dfba168
Update Extensions.cs
chenxihan Oct 7, 2022
05eecd8
Update Extensions.cs
chenxihan Oct 7, 2022
39b6869
Update Extensions.cs
chenxihan Oct 8, 2022
61b2aa3
Merge branch 'Ourpalm:master' into master
chenxihan Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ILRuntime/CLR/Utils/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ public static List<IType> GetParamList(this MethodReference def, ILRuntime.Runti
{
name = t.FullName + "[]";
}
else if (name == gp.Name + "[0...,0...]")
Copy link
Collaborator

@liiir1985 liiir1985 Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该修改会导致函数调用时产生额外的不必要GC Alloc，需要换个方式来识别，这个方法是高频执行方法，需要对这个主意

{
name = t.FullName + "[,]";
}
else
{
/*name = name.Replace("<" + gp.Name + ">", "<" + ga.FullName + ">");
Expand Down