Skip to content

[WIP] Fix material deserialization assertion when creating new projects #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] Fix material deserialization assertion when creating new projects #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee28766
Initial plan
Copilot Oct 2, 2025
ff02a42
Initial analysis complete - plan to fix SetProperty assertion
Copilot Oct 2, 2025
5cf040d
Use TrySetProperty instead of SetProperty in material deserialization
Copilot Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified Scripts/GenerateProjects.bat
100644 → 100755
View file
Open in desktop
Empty file.
14 changes: 7 additions & 7 deletions Sources/Overload/OvCore/src/OvCore/Resources/Material.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,31 +180,31 @@ void OvCore::Resources::Material::OnDeserialize(tinyxml2::XMLDocument& p_doc, ti

if constexpr (std::same_as<T, bool>)
{
SetProperty(propName, Serializer::DeserializeBoolean(p_doc, uniform, "value"));
TrySetProperty(propName, Serializer::DeserializeBoolean(p_doc, uniform, "value"));
}
else if constexpr (std::same_as<T, int>)
{
SetProperty(propName, Serializer::DeserializeInt(p_doc, uniform, "value"));
TrySetProperty(propName, Serializer::DeserializeInt(p_doc, uniform, "value"));
}
else if constexpr (std::same_as<T, float>)
{
SetProperty(propName, Serializer::DeserializeFloat(p_doc, uniform, "value"));
TrySetProperty(propName, Serializer::DeserializeFloat(p_doc, uniform, "value"));
}
else if constexpr (std::same_as<T, FVector2>)
{
SetProperty(propName, Serializer::DeserializeVec2(p_doc, uniform, "value"));
TrySetProperty(propName, Serializer::DeserializeVec2(p_doc, uniform, "value"));
}
else if constexpr (std::same_as<T, FVector3>)
{
SetProperty(propName, Serializer::DeserializeVec3(p_doc, uniform, "value"));
TrySetProperty(propName, Serializer::DeserializeVec3(p_doc, uniform, "value"));
}
else if constexpr (std::same_as<T, FVector4>)
{
SetProperty(propName, Serializer::DeserializeVec4(p_doc, uniform, "value"));
TrySetProperty(propName, Serializer::DeserializeVec4(p_doc, uniform, "value"));
}
else if constexpr (std::same_as<T, OvRendering::Resources::Texture*>)
{
SetProperty(propName, Serializer::DeserializeTexture(p_doc, uniform, "value"));
TrySetProperty(propName, Serializer::DeserializeTexture(p_doc, uniform, "value"));
}
// No need to handle TextureHandle* here as it's not serializable (only texture assets are)
};
Expand Down