-
Notifications
You must be signed in to change notification settings - Fork 1
Aerosol Water Calculation #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
samfrederick
wants to merge
39
commits into
main
Choose a base branch
from
zsr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
ed77d98
Add test yaml file for aerosol water calculation
b24fa6b
Add yaml files for initial gas and aerosol state
16f28d2
Add shell script for executing ZSR test
d1274f2
Add main wrapper script for testing aerosol water calculation. Curren…
6f5e55f
Include example script for aerosol water calc.
ccaa3d9
Add IonPair struct for ZSR calculations (either EQSAM or Jacobson bas…
b96ad10
Add method for calculating aerosol water content. NOTE: molecular wei…
e486cb7
Add parsing of aerosol water sub model attributes. NOTE: current impl…
cb6e9a9
Add vector container for ion pairs, aerosol_water data structure for …
8375e95
Add AerosolWater data structure declaration
632b38e
Remove hard-coded ionpair instances, use aerosol_sp_name_idx map to a…
62f9cfb
Change ion_quantities to a map and add an additional map for holding …
91bddba
Add aerowater_model to public attributes and template some commented …
63a848d
Change ion_quantities to maps and add map for ion molecular weights
aa758e4
Revise team_invoke arguments (major change is passing the aerosol mod…
af22bd4
Add variables for index location of RH and aqueous phase water, updat…
7e4324c
Update IonPair definition to use primitive types
1a97fa9
Remove references to aerowater_model data structure, restucture code …
1217064
Add public vars to AMD: number of aerosol water ion pairs, 1d dual v…
bed04b0
Utilize aerosolmodel_constdata instead of aerosolmodel_data, update c…
da66003
Merge branch 'main' into zsr
2802205
Merge branch 'main' into zsr
9e5cef5
Remove deprecated use of std::string variables
9c5be0c
Use tines library instead of std library for various math functions
c38d194
Fix compile error (reference to nonexistent function), replace with c…
685a12d
Add basic schematic for aerosol water unit test based on the SIMPOL t…
fb1e406
Merge branch 'main' into zsr
1e2689f
Change references to state to utilize 1d view based on TChem conventi…
ef162c9
Swap out use of conventional state array with 1D view consistent with…
9c87655
Clarify that the aerosol water model uses ZSR method
b59ec86
Add constant definitions for water molality and water molecular weight
2753580
Replace hard-coded value with values from TChem_Util.hpp
6394b8b
Add loop over batch members and inner loop over RH for calculating wa…
83a2430
Remove deprecated code
0b0b5a4
Change type of state variable to const
efca258
Use 1d view value and real types via the aerosol_water_single_particl…
e8fb939
Removed unused ion index variable
3ee5ef4
Fix bug with state variable having wrong view type declaration
dd5c5da
Fix bug with loop over RH (ensure it starts at zero), assign aerosol …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.