Skip to content

RTF Writer: Indentation - Add missing commands and don't set if == 0. #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

RTF Writer: Indentation - Add missing commands and don't set if == 0. #2836

wants to merge 8 commits into from
+82 −18

Conversation

rasamassen
Copy link

@rasamassen rasamassen commented Oct 4, 2025 •
edited
Loading

Description

Add hanging and firstLineChars. Don't set values if == 0 because otherwise firstLine[Chars] and hanging will be in conflict.

Fixes # (issue)

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@rasamassen rasamassen changed the title Indentation - Add missing commands and don't set if == 0. RTF Writer: Indentation - Add missing commands and don't set if == 0. Oct 4, 2025
@coveralls
Copy link

coveralls commented Oct 4, 2025 •
edited
Loading

Coverage Status

coverage: 96.758% (+0.001%) from 96.757%
when pulling 993eb58 on rasamassen:indentation
into 0ab0b49 on PHPOffice:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasamassen @coveralls