-
Notifications
You must be signed in to change notification settings - Fork 1
Commentary #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Commentary #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattsAttack
previously approved these changes
Apr 6, 2025
Contributor
MattsAttack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the code @lishaduck writes is so pretty and perfect. Keep up the good work self!
8bb2254 to
9bef65a
Compare
This prevents in import cycle.
This lets us get comments.
Co-authored-by: Matthew Wasser <[email protected]>
Co-authored-by: Matthew Wasser <[email protected]>
Co-authored-by: Eli <[email protected]>
Co-authored-by: Matthew Wasser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in commenting support
Closes: @MattsAttack's ambitions
Type of Change
Checklist
Ideally, include relevant tests that fail without this PR but pass with it (if applicable).NEVER!Tested on