Skip to content

Conversation

@lishaduck
Copy link
Member

@lishaduck lishaduck commented Apr 5, 2025

Description

This PR adds in commenting support

Closes: @MattsAttack's ambitions


Type of Change

  • ✨ New feature
  • 🐛 Bug fix

Checklist

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Fill out this template.
  • Log your hours.
  • Check that commits follow the Angular commit convention, more or less.
  • Ideally, include relevant tests that fail without this PR but pass with it (if applicable). NEVER!

Tested on

What device(s) have you tested this on?
Delete all non-applicable examples.

  • CI
  • macOS 14
  • Ubuntu 24.04
  • Windows 10
  • etc.

@lishaduck lishaduck self-assigned this Apr 5, 2025
@codecov
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 5.70175% with 215 lines in your changes missing coverage. Please review.

Project coverage is 20.33%. Comparing base (5aae8e2) to head (5efa212).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eatures/home/presentation/home/create_comment.dart 0.00% 55 Missing ⚠️
...eatures/home/presentation/home/post_view_page.dart 0.00% 36 Missing ⚠️
.../lib/src/features/home/presentation/home/post.dart 3.33% 29 Missing ⚠️
...b/src/features/home/presentation/home/comment.dart 0.00% 24 Missing ⚠️
...ib/src/features/home/application/post_service.dart 0.00% 19 Missing ⚠️
.../lib/src/features/home/presentation/home/feed.dart 36.00% 16 Missing ⚠️
...pp/lib/src/features/home/data/post_repository.dart 0.00% 13 Missing ⚠️
...ib/src/features/home/application/feed_service.dart 25.00% 9 Missing ⚠️
packages/app/lib/src/app/create_post.dart 0.00% 5 Missing ⚠️
...p/lib/src/features/home/domain/comment_entity.dart 0.00% 3 Missing ⚠️
... and 4 more
Files with missing lines Coverage Δ
packages/app/lib/src/app/router.dart 69.38% <ø> (ø)
.../app/lib/src/features/home/domain/post_entity.dart 0.00% <ø> (ø)
packages/app/lib/src/app/bootstrap.dart 17.64% <0.00%> (-0.54%) ⬇️
...ib/src/features/home/domain/post_model_entity.dart 0.00% <0.00%> (ø)
...b/src/features/home/domain/comment_dto_entity.dart 0.00% <0.00%> (ø)
...ages/app/lib/src/features/home/domain/post_id.dart 0.00% <0.00%> (ø)
...p/lib/src/features/home/domain/comment_entity.dart 0.00% <0.00%> (ø)
packages/app/lib/src/app/create_post.dart 1.78% <0.00%> (-0.04%) ⬇️
...ib/src/features/home/application/feed_service.dart 20.83% <25.00%> (-1.12%) ⬇️
...pp/lib/src/features/home/data/post_repository.dart 32.20% <0.00%> (-9.11%) ⬇️
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MattsAttack MattsAttack marked this pull request as ready for review April 6, 2025 13:09
@MattsAttack MattsAttack requested a review from a team as a code owner April 6, 2025 13:09
MattsAttack
MattsAttack previously approved these changes Apr 6, 2025
Copy link
Contributor

@MattsAttack MattsAttack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of the code @lishaduck writes is so pretty and perfect. Keep up the good work self!

@lishaduck lishaduck force-pushed the pull-to-refresh-followups branch from 8bb2254 to 9bef65a Compare April 6, 2025 15:13
Base automatically changed from pull-to-refresh-followups to main April 6, 2025 15:23
@lishaduck lishaduck dismissed MattsAttack’s stale review April 6, 2025 15:23

The base branch was changed.

Merged via the queue into main with commit f22daa5 Apr 6, 2025
13 of 14 checks passed
@lishaduck lishaduck deleted the commentary branch April 6, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants