Skip to content

Conversation

@lishaduck
Copy link
Member

Thanks for contributing!
Provide a description of your changes below and a general summary in the title.
Please look at the following checklist to ensure that your PR can be accepted quickly:

Once you've read over these comments, you should delete them.

Description

Describe your changes in a sentence or two.

This PR...

Which issue does this close?
If none, quickly write up a more detailed issue so any non-development-related discussion can go there.

Closes: #issue


Type of Change

Delete all non-applicable categories.

  • ✨ New feature
  • 🐛 Bug fix
  • 💥 Breaking change
  • 📝 Documentation
  • ♻️ Code refactor
  • 🎨 Style
  • ⚡️ Performance improvements
  • 🧹 Reduce tech debt
  • 🔥 Remove obsolete, unused things
  • 🧪 Test
  • 💚 CI
  • 🛠️ Build configuration change
  • ⏪️ Revert
  • 🗑️ Chore

Checklist

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Fill out this template.
  • Log your hours.
  • Check that commits follow the Angular commit convention, more or less.
  • Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

What device(s) have you tested this on?
Delete all non-applicable examples.

  • CI
  • macOS 14
  • Ubuntu 24.04
  • Windows 10
  • etc.

@lishaduck lishaduck requested a review from a team as a code owner May 23, 2025 13:49
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 22.50000% with 62 lines in your changes missing coverage. Please review.

Project coverage is 20.08%. Comparing base (26e2cfe) to head (2b9d940).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ib/src/features/home/application/post_service.dart 0.00% 16 Missing ⚠️
...eatures/home/presentation/home/post_view_page.dart 0.00% 8 Missing ⚠️
.../lib/src/features/home/presentation/home/feed.dart 25.00% 6 Missing ⚠️
...c/features/auth/presentation/auth/log_in_page.dart 0.00% 5 Missing ⚠️
.../features/auth/presentation/auth/sign_up_page.dart 0.00% 5 Missing ⚠️
packages/app/lib/src/app/wrapper.dart 20.00% 4 Missing ⚠️
.../lib/src/features/home/presentation/home/post.dart 60.00% 4 Missing ⚠️
...b/src/features/home/presentation/home/comment.dart 0.00% 3 Missing ⚠️
...eatures/home/presentation/home/create_comment.dart 0.00% 3 Missing ⚠️
.../src/features/map/presentation/items/map_page.dart 25.00% 3 Missing ⚠️
... and 4 more
Files with missing lines Coverage Δ
packages/app/lib/src/app/bootstrap.dart 17.64% <ø> (ø)
packages/app/lib/src/app/wrapper_page.dart 100.00% <100.00%> (ø)
...ures/home/presentation/home/feed_routing_page.dart 100.00% <100.00%> (ø)
...atures/home/presentation/home/local_feed_page.dart 83.33% <100.00%> (ø)
...atures/home/presentation/home/world_feed_page.dart 100.00% <100.00%> (ø)
...b/src/features/settings/domain/settings_model.dart 100.00% <ø> (ø)
packages/app/lib/src/app/app.dart 4.54% <50.00%> (ø)
...ttings/presentation/preferences/settings_page.dart 43.47% <50.00%> (ø)
packages/app/lib/src/utils/hooks.dart 0.00% <0.00%> (ø)
packages/app/lib/src/app/create_post.dart 1.78% <50.00%> (ø)
... and 10 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@lishaduck
Copy link
Member Author

Blocked on dart-lang/sdk#60784.

@lishaduck lishaduck added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit f56f04a May 29, 2025
16 checks passed
@lishaduck lishaduck deleted the upgrade branch May 29, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants