Skip to content

Commit

Permalink
Miscellaneous housekeeping.
Browse files Browse the repository at this point in the history
  • Loading branch information
c-lipka committed Sep 16, 2016
1 parent 23f936a commit 08262ab
Show file tree
Hide file tree
Showing 5 changed files with 104 additions and 9 deletions.
100 changes: 97 additions & 3 deletions changes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,10 @@ Miscellaneous Improvements
Fixed or Mitigated Issues Reported by Static Code Analysis
----------------------------------------------------------

- CID 967377: Uninitialized pointer field
- CID 967399: Uninitialized pointer field
- CID 967400: Uninitialized pointer field
Coverity Scan defects targeted deliberately:

- CID 967377: Uninitialized pointer field
- CID 967400: Uninitialized pointer field
- CID 1129016: Uninitialized pointer read
- CID 1129017: Uninitialized scalar variable
- CID 1372548: Non-virtual destructor
Expand Down Expand Up @@ -224,6 +225,99 @@ Fixed or Mitigated Issues Reported by Static Code Analysis
- CID 1372656: Structurally dead code
- CID 1372657: Unused value

Coverity Scan defects eliminated in passing:

- CID 967238: Unchecked return value from library
- CID 967239: Unchecked return value from library
- CID 967252: Logically dead code
- CID 967255: Logically dead code
- CID 967266: Division or modulo by float zero
- CID 967267: Division or modulo by float zero
- CID 967272: Dereference after null check
- CID 967284: Unsigned compared against 0
- CID 967286: Various
- CID 967290: Dereference null return value
- CID 967291: Out-of-bounds write
- CID 967292: Out-of-bounds access
- CID 967293: Out-of-bounds access
- CID 967294: Out-of-bounds access
- CID 967305: Dereference before null check
- CID 967306: Dereference before null check
- CID 967307: Dereference before null check
- CID 967310: Sizeof not portable
- CID 967333: Uninitialized scalar variable
- CID 967334: Uninitialized scalar variable
- CID 967335: Uninitialized scalar variable
- CID 967336: Uninitialized scalar variable
- CID 967337: Uninitialized scalar variable
- CID 967338: Uninitialized scalar variable
- CID 967339: Uninitialized scalar variable
- CID 967340: Uninitialized scalar variable
- CID 967341: Uninitialized scalar variable
- CID 967342: Uninitialized scalar variable
- CID 967343: Uninitialized scalar variable
- CID 967344: Uninitialized scalar variable
- CID 967345: Uninitialized scalar variable
- CID 967346: Uninitialized scalar variable
- CID 967347: Uninitialized scalar variable
- CID 967348: Uninitialized scalar variable
- CID 967349: Uninitialized scalar variable
- CID 967350: Uninitialized pointer read
- CID 967351: Uninitialized scalar variable
- CID 967352: Uninitialized scalar variable
- CID 967353: Uninitialized scalar variable
- CID 967354: Uninitialized scalar variable
- CID 967355: Uninitialized scalar variable
- CID 967356: Uninitialized scalar variable
- CID 967357: Uninitialized scalar variable
- CID 967366: Uninitialized scalar variable
- CID 967367: Uninitialized scalar variable
- CID 967368: Uninitialized scalar variable
- CID 967369: Uninitialized pointer field
- CID 967370: Uninitialized scalar field
- CID 967371: Uninitialized pointer field
- CID 967372: Uninitialized pointer field
- CID 967373: Uninitialized pointer field
- CID 967374: Uninitialized pointer field
- CID 967375: Uninitialized pointer field
- CID 967376: Uninitialized pointer field
- CID 967385: Uninitialized pointer field
- CID 967387: Uninitialized scalar field
- CID 967392: Uninitialized pointer field
- CID 967398: Uninitialized pointer field
- CID 967408: Uninitialized pointer field
- CID 986459: Logically dead code
- CID 986460: Dereference before null check
- CID 986461: Uninitialized scalar variable
- CID 1129012: Out-of-bounds write
- CID 1129013: Out-of-bounds read
- CID 1372531: Calling risky function
- CID 1372532: Division or modulo by float zero
- CID 1372534: Out-of-bounds access
- CID 1372535: Out-of-bounds access
- CID 1372536: Out-of-bounds access
- CID 1372537: Out-of-bounds access
- CID 1372538: Dereference before null check
- CID 1372539: String not null terminated
- CID 1372540: Uninitialized pointer field
- CID 1372545: Unused value
- CID 1372565: Unchecked dynamic_cast
- CID 1372575: Unchecked dynamic_cast
- CID 1372599: Dereference null return value
- CID 1372613: Uninitialized scalar variable
- CID 1372614: Uninitialized scalar variable
- CID 1372615: Uninitialized scalar variable
- CID 1372616: Uninitialized scalar variable
- CID 1372617: Uninitialized scalar variable
- CID 1372619: Uninitialized scalar variable
- CID 1372620: Uninitialized scalar variable
- CID 1372621: Uninitialized scalar variable
- CID 1372622: Uninitialized scalar variable
- CID 1372623: Uninitialized scalar variable
- CID 1372624: Uninitialized scalar variable
- CID 1372625: Uninitialized scalar variable
- CID 1372627: Uninitialized scalar variable

Fixed or Mitigated Bugs
-----------------------

Expand Down
8 changes: 4 additions & 4 deletions source/backend/povray.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ namespace
using namespace pov;
using namespace pov_base;

/// primary developers
/// Primary Developers
const char *PrimaryDevelopers[] =
{
"Chris Cason",
Expand All @@ -127,7 +127,7 @@ const char *PrimaryDevelopers[] =
NULL
};

/// assisting developers
/// Assisting Developers
const char *AssistingDevelopers[] =
{
"Nicolas Calimet",
Expand All @@ -136,16 +136,16 @@ const char *AssistingDevelopers[] =
"Christoph Hormann",
"Nathan Kopp",
"Juha Nieminen",
"William F. Pokorny",
NULL
};

/// contributing developers
/// Past Contributing Developers
const char *ContributingDevelopers[] =
{
"Steve Anger",
"Eric Barish",
"Dieter Bayer",
"Denis Bodor",
"David K. Buck",
"Nicolas Calimet",
"Chris Cason",
Expand Down
2 changes: 1 addition & 1 deletion source/base/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
#define OFFICIAL_VERSION_STRING "3.7.1"
#define OFFICIAL_VERSION_NUMBER 371

#define POV_RAY_PRERELEASE "x.potential.8787796"
#define POV_RAY_PRERELEASE "alpha.8789352"

#if (POV_RAY_IS_AUTOBUILD == 1) && ((POV_RAY_IS_OFFICIAL == 1) || (POV_RAY_IS_SEMI_OFFICIAL == 1))
#ifdef POV_RAY_PRERELEASE
Expand Down
1 change: 1 addition & 0 deletions source/core/support/imageutil.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,7 @@ static int torus_image_map(const Vector3d& EPoint, const ImageData *image, DBL *
*
******************************************************************************/

/// @author Denis Bodor
static int angular_image_map(const Vector3d& EPoint, const ImageData *image, DBL *u, DBL *v)
{
DBL len, r;
Expand Down
2 changes: 1 addition & 1 deletion unix/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.7.1-x.potential.8787796
3.7.1-alpha.8789352

0 comments on commit 08262ab

Please sign in to comment.