HomePosition: only set home position using GNSS if bit 0 in EKF2_GPS_CTRL is active#26378
Merged
mahima-yoga merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 88 byte (0 %)]px4_fmu-v6x [Total VM Diff: 88 byte (0 %)]Updated: 2026-01-30T09:41:22 |
0f08cf3 to
0b7d53c
Compare
sfuhrer
requested changes
Jan 29, 2026
768fcf0 to
53a50f3
Compare
53a50f3 to
3bdd053
Compare
…CTRL is active If the vehicle position is not set by GNSS, then the home position should not be either.
3bdd053 to
0f7a4db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
The home position was being set using raw GNSS data even when the vehicle position estimate did not use GNSS. See video:
Screencast.from.01-29-2026.02.29.37.PM.webm
Solution
If the vehicle position is not set by GNSS, then the home position should not be either. The proposed solutions checks whether vehicle horizontal position is using GNSS by checking if bit 0 is enabled in
EKF2_GPS_CTRL.Changelog Entry
For release notes:
Test coverage
Tested in SIH (log).
Screencast.from.01-29-2026.01.44.14.PM.webm