ensure numbers where we expected booleans parse correctly. #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean.parseBoolean expects the literal "true", which doesn't match the number 1. The fix is to parse "1" as truthy, and all other values as falsy, like Boolean.parseBoolean() does. fixes PaperMC/Velocity#1286
|
Oh, looks like it might be intentional, if there is a test for it. does that just make this velocities problem? |
|
I think this is a format change from since component serialization started using Codecs? so it's a case of adventure's tests being outdated against the newly changed spec. |
|
I'm still not 100% sure if this should change, as looking at the codecs etc, the vanilla jsonOps only parses / emits standard json bools, so this is more permissive than how minecraft behaves with json. |
kezz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean.parseBoolean expects the literal "true", which doesn't match the number 1.
The fix is to parse "1" as truthy, and all other values as falsy, like Boolean.parseBoolean() does.
fixes PaperMC/Velocity#1286
I'm assuming its meant to accept "1" as valid, seeing as it was specifically peeking for Numbers.
In velocity at least, "1" in json is emitted by the nbt component converter, from bytes