Refactor Velocity networking to be closer to vanilla #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masmc05
reviewed
Oct 19, 2025
proxy/src/main/java/com/velocitypowered/proxy/command/builtin/VelocityCommand.java
Outdated
Show resolved
Hide resolved
Comment on lines
68
to
74
| public UUID getUuid() { | ||
| return uuid; | ||
| } | ||
|
|
||
| public int getAction() { | ||
| return action; | ||
| } |
There was a problem hiding this comment.
Why keeping both getter types is necessary?
Contributor
Author
There was a problem hiding this comment.
Because the AI (Claude) wanted to make sure the code compiled and it sometimes chose to amend the existing code and sometimes add in getters. I didn't steer it in that direction.
Again, while it's redundant, it's a nit that someone else can fix.
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
|
||
| public class DisconnectPacket implements MinecraftPacket { | ||
| public final class DisconnectPacket implements MinecraftPacket { |
There was a problem hiding this comment.
Why some classes like this one aren't records? It has public constructor, all final fields and record style getters, so I can't think of a reason
Contributor
Author
There was a problem hiding this comment.
I don't think it's worth converting every class to a record, it just wastes time. This feels like a very unimportant nit.
astei
force-pushed
the
astei/packet-immutable
branch
from
f572af1 to
f390682
Compare
novitpw
reviewed
Oct 20, 2025
| int expectedMinLen = packet.decodeExpectedMinLength(buf, direction, registry.version); | ||
| int expectedMaxLen = packet.decodeExpectedMaxLength(buf, direction, registry.version); | ||
| private void doLengthSanityChecks(ByteBuf buf, | ||
| com.velocitypowered.proxy.protocol.PacketCodec<? extends MinecraftPacket> codec) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really large PR, so review carefully.
This PR refactors Velocity's internal networking to use immutable(-ish) packets and splits encoding/decoding into separate codecs. This refactor isn't fully complete but there's enough to start doing more work on this.