-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add new null rods for various religions. #31393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
As much as I hate to bring balance up this early, vajra and ghanta seem to be possibly a little too good? |
Idk why you're saying you hate to do something that would make the PR better. It's a draft. I can reduce the force any time, or make any other change you like. |
- Modify weight classes for kirpan, vajra, ganta, gohei, and whisk - Reduce force of vajra - Nudge kirpan sheath sprite in belt slot - More progress on getting vajra and ghanta to equip properly (should be one in each hand when equipped and none inhand if not) (still needs work)
I just don't like discussing balance, really. Especially when the goal is clearly to just add more flavour and variety to the game. |
| /obj/item/nullrod/vajra | ||
| name = "vajra and ghanta" | ||
| desc = "A set of inseparable ritual tools." | ||
| icon_state = "vajra_and_ghanta" | ||
| worn_icon_state = null | ||
| righthand_file = 'icons/mob/inhands/religion_righthand.dmi' | ||
| inhand_icon_state = "vajra" | ||
| force = 5 | ||
| w_class = WEIGHT_CLASS_NORMAL | ||
| attack_verb = list("bludgeoned", "hit", "struck") | ||
| var/obj/item/nullrod/cleansing/ghanta/bound_ghanta = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like how this basically reimplements the two-handed component. However, that component doesn't have support for multiple items like this. There should probably be a better solution to this before merge, but i have no good ideas yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love a better solution! This isn't working.
|
Could the Islamic Curved Saber be named "Curved Saber" in-game so it can be reasonably used for any player-made religions without seeming out of place name-wise? |
I suppose. |
- Correctly stores the two items together without creating a quantum duplicate when putting into storage items. - Correctly stores the two items together if either is dropped. - Correctly stores the two items together if either is thrown (even correctly transfers the state of being thrown to the other). - Correctly drops the item if you're holding something in the right hand.
Signed-off-by: Alan <alfalfascout@users.noreply.github.com>
|
!wiki_label |
|
The curved blade can be named scimitar, shamshir, saif, jambiya, or talwar. Most people know them as scimitars. And have to agree with gatcha, please increase their size to not fit in pockets and lower to like 10 dmg due to the duo functionality. Other than that, very nice and creative. Look forward to this pr. More ideas could be the macuahuitl, the obsidian sword of the aztecs. |
I was advised by another design team member to remove all force or give them a non-rosary, non-full-antimagic effect. I am still thinking about this. |
What Does This PR Do
Adds some new null rods.
I and CRUNCH-Borg have been working on the code. I did most of the sprites Darkmight9 made inhand sprites for whisker, goad, and gohei.
Why It's Good For The Game
Just another part of my ongoing work towards religious diversity on Paradise.
Images of changes
Will add these once I have all the pictures and also once they work.
Testing
Will add this once the items work.
Declaration
Changelog
🆑AlfalfaScout, CRUNCH-Borg, Darkmight9
add: Added six or seven new null rods: a saber, vajra and ghanta, elephant goad, kirpan, gohei, and whisker.
/:cl: