Migrates /obj/item/clothing to the New Attack Chain
#31421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
1 task
ParadiseSS13-Bot
added
-Status: Awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Migrates
/obj/item/clothingto the New Attack Chain.I have done a lot of testing for this, but I recommend a test merge be performed because this is a substantial change and some interactions may have been affected.
Why It's Good For The Game
Attack chain migration good.
My noble sacrifice will spare someone else from having to wade through all the bullshit involved in migrating this item path.
Testing
I've tested all of the items whose procs I have directly altered.
Some subtypes that do funny things may have been affected, it is not certain. A TM would be good to catch anything that possibly slipped through testing.
Declaration