Do not continue to autoreload the job page if a reload fails.#504
Merged
Conversation
Autoreload causes the job page to hit the backend every couple of seconds. However, most RQ implementations set a TTL on jobs in redis. So, this polling will eventually fail. If it continues, it will do so continuously. This makes it difficult for users to set up monitoring and alerting, since these errors eventually overwhelm everything else coming from RQ dashboard. And, the refreshes are meaningless anyway. This PR stops polling on the job page if a reload fails.
Contributor
Author
|
@cjlapao Do you mind taking a look at this? We use RQ dashboard quite a bit. And this issue occasionally comes up in our monitoring and requires just that little bit more effort for our oncall rotation. |
Collaborator
|
@phil-kremidas-unitedmasters Thanks, merged. Will try to release it today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Autoreload causes the job page to hit the backend every couple of seconds. However, most RQ implementations set a TTL on jobs in redis. So, this polling will eventually fail. If it continues, it will do so continuously. This makes it difficult for users to set up monitoring and alerting, since these errors eventually overwhelm everything else coming from RQ dashboard. And, the refreshes are meaningless anyway.
This PR stops polling on the job page if a reload fails.
Type of change
Please delete options that are not relevant.
Checklist: