Skip to content

Do not continue to autoreload the job page if a reload fails.#504

Merged
cjlapao merged 1 commit into
Parallels:masterfrom
phil-kremidas-unitedmasters:patch-1
Jun 2, 2025
Merged

Do not continue to autoreload the job page if a reload fails.#504
cjlapao merged 1 commit into
Parallels:masterfrom
phil-kremidas-unitedmasters:patch-1

Conversation

@phil-kremidas-unitedmasters
Copy link
Copy Markdown
Contributor

Description

Autoreload causes the job page to hit the backend every couple of seconds. However, most RQ implementations set a TTL on jobs in redis. So, this polling will eventually fail. If it continues, it will do so continuously. This makes it difficult for users to set up monitoring and alerting, since these errors eventually overwhelm everything else coming from RQ dashboard. And, the refreshes are meaningless anyway.

This PR stops polling on the job page if a reload fails.

Type of change

Please delete options that are not relevant.

  • Documentation Change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests (pytest) that prove my fix is effective or that my feature works
  • I have updated the CHANGELOG.md file accordingly
  • I have added tests that prove my fix is effective or that my feature works

Autoreload causes the job page to hit the backend every couple of seconds. However, most RQ implementations set a TTL on jobs in redis. So, this polling will eventually fail. If it continues, it will do so continuously. This makes it difficult for users to set up monitoring and alerting, since these errors eventually overwhelm everything else coming from RQ dashboard. And, the refreshes are meaningless anyway.

This PR stops polling on the job page if a reload fails.
@phil-kremidas-unitedmasters phil-kremidas-unitedmasters marked this pull request as draft May 30, 2025 21:36
@phil-kremidas-unitedmasters phil-kremidas-unitedmasters marked this pull request as ready for review May 30, 2025 21:37
@phil-kremidas-unitedmasters
Copy link
Copy Markdown
Contributor Author

@cjlapao Do you mind taking a look at this? We use RQ dashboard quite a bit. And this issue occasionally comes up in our monitoring and requires just that little bit more effort for our oncall rotation.

@cjlapao cjlapao merged commit e812377 into Parallels:master Jun 2, 2025
6 checks passed
@cjlapao
Copy link
Copy Markdown
Collaborator

cjlapao commented Jun 2, 2025

@phil-kremidas-unitedmasters Thanks, merged. Will try to release it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants