redis-clustering support
#74
Conversation
joshuay03
force-pushed
the
redis-clustering-support
branch
2 times, most recently
from
b0e3b59 to
1a12515
Compare
|
I'm guessing we'd want to add some docs re: the things discussed in the relate issue, I'll tackle that once I've got a review and know that CI is green. |
joshuay03
force-pushed
the
redis-clustering-support
branch
2 times, most recently
from
bf77d74 to
fe9aae5
Compare
joshuay03
force-pushed
the
redis-clustering-support
branch
from
fe9aae5 to
9651eb2
Compare
| if ENV['REDIS_VERSION'] | ||
| gem 'redis', "~> #{ENV['REDIS_VERSION']}" | ||
| if (redis_version = ENV.fetch('REDIS_VERSION', nil)) | ||
| gem 'redis', "~> #{redis_version}" |
There was a problem hiding this comment.
For some reason RuboCop was only forcing fetch in some cases below, so I just went ahead and updated all of them.
|
This is looking really nice, thanks! I haven't yet had time to take a detailed look, but I will try to get that done this week. I'm thinking we should document this as a break of backwards compatibility. The migration path looks to be automatic, but upgrading will cause circuit states to be reset. That's probably not a big issue for most users. Does that make sense to you? |
joshuay03
force-pushed
the
redis-clustering-support
branch
from
9651eb2 to
cd32bc0
Compare
Yep, that makes sense since the keys are changing. Is this (CHANGELOG entry?) something you would like me to do? Or will you be handling that? |
|
@joshuay03 Sorry it's taking so long for me to get to this. It's busy season in the education industry. Just wanted you to know I haven't forgotten.
I can handle it as part of the release. |
2 participants
Closes #71.
This is a scope-cut version of buildkite#1 (it included other CI and related changes similar to #72).