Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redoing the Flow diagram #2335

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Redoing the Flow diagram #2335

wants to merge 3 commits into from

Conversation

johnsimons
Copy link
Member

This fixes inconsistencies:

  • No render if no parent message
  • Lines missing
  • No Saga icons

Saga was not displaying different statuses
In certain conditions some arrow were missing
@johnsimons johnsimons self-assigned this Apr 11, 2025
@johnsimons johnsimons requested a review from PhilBastian April 11, 2025 06:33
});

if (parentMessages.length === 0) {
console.log(`Fall back to match only on RelatedToMessageId for message with Id '${message.message_id}' matched but link could be invalid.`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.debug


switch (parentMessages.length) {
case 0:
console.log(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.warn maybe?

// Log nothing, this is what it should be
break;
default:
console.log(`Multiple parents matched for message id '${message.message_id}' possibly due to more-than-once processing, linking to all as it is unknown which processing attempt generated the message.`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably console.warn

nodes.value = layout(nodes.value, edges.value, showAddress.value);

await nextTick(() => {
fitView();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: zoom to selected message rather than zoom to fitView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants