-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redoing the Flow diagram #2335
base: master
Are you sure you want to change the base?
Redoing the Flow diagram #2335
Conversation
Saga was not displaying different statuses In certain conditions some arrow were missing
}); | ||
|
||
if (parentMessages.length === 0) { | ||
console.log(`Fall back to match only on RelatedToMessageId for message with Id '${message.message_id}' matched but link could be invalid.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.debug
|
||
switch (parentMessages.length) { | ||
case 0: | ||
console.log( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.warn maybe?
// Log nothing, this is what it should be | ||
break; | ||
default: | ||
console.log(`Multiple parents matched for message id '${message.message_id}' possibly due to more-than-once processing, linking to all as it is unknown which processing attempt generated the message.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably console.warn
nodes.value = layout(nodes.value, edges.value, showAddress.value); | ||
|
||
await nextTick(() => { | ||
fitView(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: zoom to selected message rather than zoom to fitView
This fixes inconsistencies: