Add more stdinc symbols #35
Conversation
| function SDL_GetNumAllocations(): cint; cdecl; | ||
| external SDL_LibName {$IFDEF DELPHI} {$IFDEF MACOS} name '_SDL_GetNumAllocations' {$ENDIF} {$ENDIF}; | ||
|
|
||
| (* -- Environment variables manipulation functions -- *) |
There was a problem hiding this comment.
This comment is not in the original code. See comment above.
| @@ -153,6 +153,1121 @@ const | |||
| const | |||
| SDL_FLT_EPSILON = cfloat(1.1920928955078125e-07); | |||
|
|
|||
| (* -- Memory management functions -- *) | |||
There was a problem hiding this comment.
This comment is not in the original code.
I see why you added these explanatory separator comment(s). I wonder if we should extend it (them) by a small comment to indicate that these separators are added by our project and not found in the original code. I actually tried to search for this exact line in the original code to find the place to start reviewing when I noticed it is not found in the original code :).
Maybe something like:
(* - - SEPARATOR - - (line added by SDL3-for-Pascal) *)
| function SDL_unsetenv_unsafe(const name: PAnsiChar): cint; cdecl; | ||
| external SDL_LibName {$IFDEF DELPHI} {$IFDEF MACOS} name '_SDL_unsetenv_unsafe' {$ENDIF} {$ENDIF}; | ||
|
|
||
| (* -- Character classification functions -- *) |
There was a problem hiding this comment.
This comment is not in the original code. See comment above.
| function SDL_isgraph(x: cint): cint; cdecl; | ||
| external SDL_LibName {$IFDEF DELPHI} {$IFDEF MACOS} name '_SDL_isgraph' {$ENDIF} {$ENDIF}; | ||
|
|
||
| (* -- Character manipulation functions -- *) |
There was a problem hiding this comment.
This comment is not in the original code. See comment above.
| function SDL_tolower(x: cint): cint; cdecl; | ||
| external SDL_LibName {$IFDEF DELPHI} {$IFDEF MACOS} name '_SDL_tolower' {$ENDIF} {$ENDIF}; | ||
|
|
||
| (* -- Hash functions -- *) |
There was a problem hiding this comment.
This comment is not in the original code. See comment above.
| function SDL_murmur3_32(const data: Pointer; len: csize_t; seed: cuint32): cuint32; | ||
| external SDL_LibName {$IFDEF DELPHI} {$IFDEF MACOS} name '_SDL_murmur3_32' {$ENDIF} {$ENDIF}; | ||
|
|
||
| (* -- PRNG functions -- *) |
There was a problem hiding this comment.
This comment is not in the original code. See comment above.
| function SDL_rand_bits_r(state: pcuint64): cuint32; cdecl; | ||
| external SDL_LibName {$IFDEF DELPHI} {$IFDEF MACOS} name '_SDL_rand_bits_r' {$ENDIF} {$ENDIF}; | ||
|
|
||
| (* -- Floating-point arithmetic functions -- *) |
There was a problem hiding this comment.
This comment is not in the original code. See comment above.
|
Personally I don't see much value in marking the separators as not present in the original source, though on the other hand, I'm also not adamant about keeping them. Edit to your liking and I'll adapt any follow-up PRs accordingly. |
|
I'd prefer them marked in some way, but it is no high priority, I guess. So let's go with them as present. :) |
Free-Pascal-meets-SDL-Website
merged commit c129396
into
PascalGameDevelopment:main
This PR adds some symbols missing from
SDL_stdinc.inc. There's still a lot more to go, but I'd prefer to avoid having a single giant PR.