Type comparison operators #420
Conversation
| var type = rightOperand as Type; | ||
| if (type == null) | ||
| { | ||
| throw new InvalidOperationException(@"The right operand of '-is' must be a type."); |
There was a problem hiding this comment.
Why a verbatim string literal here?
There was a problem hiding this comment.
To emphasise localisable text only literal.
There was a problem hiding this comment.
@ygra, I think that some tools such as Resharper will throw a warning here mentioning "possibly localizable string". Making a literal verbatim is really a way to suppress this warning. So:
a) I don't think we generally use this practice in Pash code
b) that's really a localizable string, so it would be improper to just suppress the warning. If we one day will ultimately decide to localize Pash (what's unlikely but possible), we'll need to localize it.
So I don't think that you should use verbatim string literal here. Better get rid of that.
|
Look, guys, we have some problems on AppVeyor. Seems manageable if we update project to .NET4.5. I don't think that problem is caused by the changes in this PR. |
|
@SemyonL could you please add some tests? |
Added type comparison operators.