General improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioND
had a problem deploying
to
github-pages
GitHub Actions
Failure
AntonioND
had a problem deploying
to
github-pages
GitHub Actions
Failure
AntonioND
had a problem deploying
to
github-pages
GitHub Actions
Failure
AntonioND
changed the title
Flushing all the data cache is a very costly operation, and it isn't needed because we're only copying the shadow OAM buffer from main RAM to OAM.
AntonioND
had a problem deploying
to
github-pages
GitHub Actions
Failure
AntonioND
had a problem deploying
to
github-pages
GitHub Actions
Failure
Commit 3d43ca2 ("Turn passthrough chapter into an appendix") forgot to update chapter numbers in many places. This commit fixes that.
AntonioND
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit big, but individual commits are easier to understand.
I've fixed some chapter indices that I forgot to update in the last PR (I've also renamed the folders of the code examples).
I've also fixed a data cache flush when updating the OAM buffer. It was too broad of a flush, it's better to flush just the affected range.