Initial theming implementation#6200
Draft
PJacek wants to merge 12 commits intoPathOfBuildingCommunity:devfrom
Draft
Initial theming implementation#6200PJacek wants to merge 12 commits intoPathOfBuildingCommunity:devfrom
PJacek wants to merge 12 commits intoPathOfBuildingCommunity:devfrom
Conversation
|
Hello! I'm very interested in this feature since the full black background of PoB has always been a problem for me. I just found this PR (from #5130) that seems to have done a lot of work already. What is missing here to keep moving forward? I don't know Lua at all but I can still offer my help if needed if you need some testing. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can now be considered an alpha version. Rebased on top of
dev. The overall architecture is finished but there are still some WIP leftovers and the specific implementation and style are potentially subject to change.__indexmetamethod to fall back to the "default" hardcoded colours scheme, so there is always some colour definition available. I plan to add the ability to define a parent theme which would enable the creation of thin derivative themes.